feat: make BasicBlock::new publicly accessible - #601
Merged
Conversation
TheDan64
self-requested a review
September 3, 2025 05:59
TheDan64
approved these changes
Sep 3, 2025
Owner
|
Thanks! |
Owner
|
@fuqiuluo please add a doc comment to the method; thanks! |
Contributor
Author
|
done! add a doc comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Makes the
BasicBlock::newmethod publicly accessible by changing its visibility frompub(crate)topub.Motivation
Currently, the
BasicBlock::newmethod is only accessible within the crate, which limits external users' ability to create BasicBlock instances directly fromLLVMBasicBlockRef. This change allows users to have more direct control over BasicBlock creation when working with LLVM C API interop scenarios.Changes
BasicBlock::newfrompub(crate)topubinsrc/basic_block.rsChecklist
cargo clippyand updated portions of code pertaining to my changesNotes
This is a non-breaking change that only expands the public API surface. The method signature and behavior remain unchanged - it still safely handles null pointer checks and returns
Option<Self>.