Skip to content

Project: HashMap: Fix hash map lint errors - #30356

Merged
mao-sz merged 2 commits into
TheOdinProject:mainfrom
goran1010:fix/project_hash_map_lint
Nov 7, 2025
Merged

Project: HashMap: Fix hash map lint errors #30356
mao-sz merged 2 commits into
TheOdinProject:mainfrom
goran1010:fix/project_hash_map_lint

Conversation

@goran1010

@goran1010 goran1010 commented Nov 4, 2025

Copy link
Copy Markdown
Member

Because

This lesson had a missing heading for a note box, and completely wrong indentation levels throughout.

This PR

  • Add a level 4 heading to a note-box
  • Remove unnecessary indentation of non-list content
  • Change the indentation of ordered list items to the correct 3 spaces, to make sure the level 4 heading for the note-box can render properly

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions Bot added the Content: JavaScript Involves the JavaScript course label Nov 4, 2025

@mao-sz mao-sz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @goran1010. Can the same fixes be applied to the Ruby version of this project as well please?

@mao-sz
mao-sz merged commit f2017e4 into TheOdinProject:main Nov 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content: JavaScript Involves the JavaScript course

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants