You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
lesson talks about extra eslint config for globals but doesn't share it, it's just one line config change to stop it yelling so i think it should be included in lesson.
Huh, TIL that globals changed their stance on adding new environments as of 2 years ago (sindresorhus/globals#82).
I'm actually still going to close this one though, but thank you for the PR nonetheless.
Even if it's just a 1-2 line config change, we don't need to list every possible resolution. The current wording also says "the most straightforward resolution" for explicit importing and I personally stand by that because that gives you clear knowledge where identifiers are coming from (so they're not just magic globals) but also give you type information because the LSP can read the imports and Vitest's type files. As true globals, they'll literally just be globals typed as any. This reasoning isn't necessary for the lesson to go into though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
lesson talks about extra eslint config for globals but doesn't share it, it's just one line config change to stop it yelling so i think it should be included in lesson.
This PR
Issue
Closes #XXXXX
Additional Information
Pull Request Requirements
location of change: brief description of changeformat, e.g.Intro to HTML and CSS lesson: Fix link textBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PRIssuesection