Use &Path instead of &str for path in write_to_path#52
Open
tarneaux wants to merge 3 commits into
Open
Conversation
Since all underlying crates use a &Path as the type for writing, it makes much more sense to just use that as the type for `write_to_path`, especially since strs can be freely cast to Paths, but Paths can't be cast to strs all the time (since on some OSes, non-unicode characters are allowed in paths).
Collaborator
|
How about |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since all underlying crates use a &Path as the type for writing, it makes much more sense to just use that as the type for
write_to_path, especially since strs can be freely cast to Paths, but Paths can't be cast to strs all the time (since on some OSes, non-unicode characters are allowed in paths).