Add create_new method#53
Open
cetra3 wants to merge 3 commits into
Open
Conversation
Collaborator
|
Hey thanks - could we add a test pretty pls 🙏 Cc/ @Serial-ATA 🍏 thoughts ? |
Contributor
|
This would probably be better as an associated function: impl Tag {
pub fn empty(tag_type: TagType, config: Config) -> Box<dyn AudioTag + Send + Sync> {
// ...
}
}Just to avoid having an extra error variant. |
Serial-ATA
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
create_newmethod to create a tag from scratch. It also fixes an error whereby the tag type is specified, but it still tries to read it from the path, and fails.Resolves #35