Move columnar_support to the core library#730
Merged
frankmcsherry merged 1 commit intoTimelyDataflow:master-nextfrom Apr 25, 2026
Merged
Move columnar_support to the core library#730frankmcsherry merged 1 commit intoTimelyDataflow:master-nextfrom
columnar_support to the core library#730frankmcsherry merged 1 commit intoTimelyDataflow:master-nextfrom
Conversation
Moves the columnar arrangement / container infrastructure from the `examples/columnar/columnar_support/` tree into `src/columnar/` as a public, experimental module. API and internals are explicitly marked as unstable in the module-level docs; rough edges (`unimplemented!` `ContainerBytes`, eager-consolidate `leave_dynamic`, single-`U` `join_function`) are listed up front. Also generalizes the dynamic-scope helpers: `DynTime<TOuter, T>` is now parametric (was hardcoded to `Product<u64, PointStamp<u64>>`), and `leave_dynamic` carries matching bounds plus a `level > 0` assert. Updates the in-tree consumers: `examples/columnar/main.rs` and `interactive/examples/ddir_col.rs` switch from path-mounted modules to `use differential_dataflow::columnar`. `ddir_vec.rs` + `interactive/src/ir.rs` gain a `RowLike` impl for `SmallVec<A>`, used by the vec-backed ddir example for its row representation. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lightly updates and moves the
columnar_supportexample code into the core library, to evolve it less confusingly. The main changes as part of the PR are splitting the 2kLOC file into smaller parts, and introducing efficiencies around work that should be a sequential pass (e.g. filtering zeros, partitioning by time).