ev: Announce ev feature - #503
Closed
poohnet wants to merge 1 commit into
Closed
Conversation
4 tasks
rtrbt
added a commit
that referenced
this pull request
Jul 8, 2026
- No hardware detection: Each charger with this module is assumed to have the PLC modem - Not checking is_enabled(): The feature announces that the hardware is available, not that the charger is configured to use it.
rtrbt
added a commit
that referenced
this pull request
Jul 8, 2026
- No hardware detection: Each charger with this module is assumed to have the PLC modem - Not checking is_enabled(): The feature announces that the hardware is available, not that the charger is configured to use it.
Member
|
Close, but the feature has to be iso15118, set by the corresponding module. Features identify available hardware and the EV module is intended to be ported to chargers and energy managers w/o the PLC modem. (For example to be able to configure known vehicles for the central management) PS: Sorry for the commit reference spam, I've had to fight git a bit :D |
Contributor
Author
|
Thanks Erik :-) |
poohnet
added a commit
to poohnet-org/evcc
that referenced
this pull request
Jul 9, 2026
Requires WARP4 firmware announcing the ev feature, see Tinkerforge/esp32-firmware#503. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This announces the ev module in
info/features, analogous to how other modules (evse, meters, nfc, phase_switch, ...) advertise their availability.Motivation
evcc is adding WARP4 support including reading the vehicle SoC and MAC address from the
ev/stateAPI (see evcc-io/evcc#31446). evcc detects optional WARP functionality at runtime viaGET /info/features, which works for all APIs it consumes exceptev/state: the ev module currently registers no feature, so evcc would have to probe the endpoint and treat a failure as "not available". That cannot distinguish a device without the ev module from a transient error. The evcc maintainer asked whether the module could be announced as a feature instead (evcc-io/evcc#31446 (comment): evcc-io/evcc#31446 (comment)), so feature detection stays consistent.Change
Ev::setup()callsapi.addFeature("ev"), following the convention of other software-only modules (em_common, nfc_bricklet).Since the ev module is currently only part of the WARP4 build, the "ev" feature also identifies WARP4 devices with ISO 15118 vehicle data support. The typed
featureunion inweb/src/ts/api.tsis intentionally left untouched since the web frontend does not check this feature itself (same as front_panel, ocpp_debug, evse_gp_output).The evcc PR will switch to feature-based detection once this is released.
/cc @rtrbt (you were already pinged in the evcc PR)