Docs: is_process_trusted() silently returns True on framework load failure — behavior undocumented#221
Open
kumburovicbranko682-boop wants to merge 1 commit into
Conversation
…ilure — behavior undocumented The function is_process_trusted() is the public API callers use to decide whether to show accessibility permission prompts. Both the _load_frameworks and the main try/except paths return True on failure (lines ~43, ~95), meaning callers will believe accessibility is granted when ctypes loading or the trust check itself throws. This "fail open" design is intentional (so the app doesn't block on non-macOS platforms or broken frameworks), but it is not documented anywhere. A maintainer debugging a user report of "Mouser said permissions were fine but hooks don't work" has no indication that this is the cause. The module docstring and function docstring are both missing. Affected files: accessibility.py Signed-off-by: kumburovicbranko682-boop <295886834+kumburovicbranko682-boop@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The function is_process_trusted() is the public API callers use to decide whether to show accessibility permission prompts. Both the _load_frameworks and the main try/except paths return True on failure (lines ~43, ~95), meaning callers will believe accessibility is granted when ctypes loading or the trust check itself throws. This "fail open" design is intentional (so the app doesn't block on non-macOS platforms or broken frameworks), but it is not documented anywhere. A maintainer debugging a user report of "Mouser said permissions were fine but hooks don't work" has no indication that this is the cause. The module docstring and function docstring are both missing.
Severity:
mediumFile:
core/accessibility.pySolution
Add a docstring to is_process_trusted:
Changes
core/accessibility.py(modified)Testing