Adding instrumentation for github.com/tidwall/buntdb (WIP)#1
Open
TomRoSystems wants to merge 36 commits into
Open
Adding instrumentation for github.com/tidwall/buntdb (WIP)#1TomRoSystems wants to merge 36 commits into
TomRoSystems wants to merge 36 commits into
Conversation
MrAlias
reviewed
Nov 19, 2021
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| // Package test validates the splunkkafka instrumentation with the default SDK. |
There was a problem hiding this comment.
Suggested change
| // Package test validates the splunkkafka instrumentation with the default SDK. | |
| // Package test validates the splunkbuntdb instrumentation with the default SDK. |
Merging suggestions from code review Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
|
I would recommend closing this in favor of signalfx#228 |
…k-otel-go into trojek-migrate-buntdb
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
…_test.go Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #1 +/- ##
=======================================
Coverage ? 77.39%
=======================================
Files ? 47
Lines ? 2358
Branches ? 0
=======================================
Hits ? 1825
Misses ? 485
Partials ? 48
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.