'prob' and 'prob_weights' argument names in Samplers

[lauramurgatroyd]

Description

Sampler.random_with_replacement takes 'prob' not 'prob_weights'. Whereas SPDHG takes 'prob_weights' and Sampler.from_function takes prob_weights. Is there a reason for this difference? Or should they all be called the same name? I found it confusing.

See discussion at: TomographicImaging/CIL-Demos#286 (comment)

Environment

import cil, sys
print(cil.version.version, cil.version.commit_hash, sys.version, sys.platform)

[MargaretDuff]

I think we were moving everything to prob_weights - I think we deprecated prob in SPDHG in preference for prob_weights. We could do the same for the random sampler?