Add a way to optionally suppress usage of std::source_location#295
Conversation
|
@ToruNiina Could you have a look at this PR, please? This is currently blocking us from upgrading to the recent version of toml11. |
|
Hi @ToruNiina, if you have a chance, could we please merge this to ensure one turn off the In some C++20 compilers, this feature is still flaky and we would like to turn it off selectively when needed 🙏 |
Add a way to optionally suppress usage of std::source_location b96acf9
|
Yesterday I triggered CI for the branch that applied these changes to the latest main branch(https://github.com/ToruNiina/toml11/tree/rerun-295). And it passed. The changes itself also looks good to me, so I'll merge it. Sorry for the delay! |
|
Thank you @ToruNiina! We are trying to transition a few more projects to C++20 and this patch would help to deal with older clang compilers (like v13.0). Do you think you could include this in a 4.5.0 release of toml11? 🙏 |
|
Hi @ToruNiina, Can you potentially draft a new release for TOML11 with fixes like those? 🙏 |
Switch to C++20. AMReX is making the switch soon (AMReX-Codes/amrex#4840) and is preparing CI in AMReX-Codes/amrex#4976 so we can also generally pull up the requirements. - [x] wait for 26.03 release - [x] patch [toml11](ToruNiina/toml11#295) / use clang 14+ (for CI, we can do openPMD/openPMD-api#1874 ) - [x] merge for the 26.05 release cycle --------- Co-authored-by: Weiqun Zhang <weiqunzhang@lbl.gov> Co-authored-by: Edoardo Zoni <ezoni@lbl.gov> Co-authored-by: Luca Fedeli <luca.fedeli@cea.fr>
The integrated checks for availability of
std::source_locationseem to not work correctly for Clang++ 11-13, compare this output from our failing CI:This PR adds a way to suppress usage of
std::source_location: