Skip to content

Implement Time Lapse - #16

Open
SpaceNerden wants to merge 11 commits into
TraceLTRC:masterfrom
SpaceNerden:Time_Lapse
Open

Implement Time Lapse#16
SpaceNerden wants to merge 11 commits into
TraceLTRC:masterfrom
SpaceNerden:Time_Lapse

Conversation

@SpaceNerden

Copy link
Copy Markdown
Contributor

Also added support for raw ore blocks.

@SpaceNerden

Copy link
Copy Markdown
Contributor Author
2023-03-03_21-23-42.mp4

Not sure about the sound, I think it's quite long. I also don't know if it is global, like the wither spawn effects.

@dlee13

dlee13 commented Mar 4, 2023

Copy link
Copy Markdown
Collaborator

I think the sound is not global since it takes a location, And yeah, the sound is a bit long.

@SpaceNerden

Copy link
Copy Markdown
Contributor Author
2023-03-04_19-49-18.mp4

Not sure if this is better, but personally I think it's cleaner.

@dlee13

dlee13 commented Mar 5, 2023

Copy link
Copy Markdown
Collaborator

This is good.

@dlee13

dlee13 commented Mar 13, 2023

Copy link
Copy Markdown
Collaborator

-roni should be in the name as a direct reference to how Kronii named her personal items in minecraft

Comment thread src/main/java/xyz/holocons/mc/holoitemsrevamp/collection/CollectionManager.java Outdated
@dlee13

dlee13 commented Sep 1, 2023

Copy link
Copy Markdown
Collaborator

I've been thinking about this some more just now, and the name doesn't make sense. A time lapse goes forward in time, but this item reverts items.

@SpaceNerden

Copy link
Copy Markdown
Contributor Author

Timewarperoni? That's all I can think of that has Time in it.

Or we can go extremely creative and go Unsmelteroni lol

@dlee13

dlee13 commented Sep 1, 2023

Copy link
Copy Markdown
Collaborator

Hmmmm. None of HoloEN Advent has played Minecraft on stream yet. If they had, we could consider making this a Shiori item instead and based on the idea of restoring things from an archive.

Or Time Leaperoni. Rewinderoni?

@SpaceNerden

Copy link
Copy Markdown
Contributor Author

Yeah, making this a shiori item and naming it something like Snapshot Rewind or Rollback might be a good idea.

@dlee13

dlee13 commented Sep 8, 2023

Copy link
Copy Markdown
Collaborator

This is on hold for merging. I've decided that we'll change it into a Shiori item as well as change the implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants