Implement Verification Seal - #34
Draft
cpaca wants to merge 2 commits into
Draft
Conversation
cpaca
marked this pull request as draft
June 28, 2024 06:00
Contributor
Author
|
Ah. This one's staying in Draft form until we get 1.20.6 dependencies (most likely 1.21, honestly) It'd be better to use CartographyItemEvent or CraftItemEvent instead of InventoryClickEvent for this one, but I don't think that function exists in 1.20.1. Compiler and IDE throw an error when I try to use CartographyItemEvent, but I can find it in the documentation for 1.21 and 1.20.6. 1.20.6 docs: https://jd.papermc.io/paper/1.20.6/io/papermc/paper/event/player/CartographyItemEvent.html |
dlee13
reviewed
Jul 13, 2024
| default void onPlayerToggleSneak(PlayerToggleSneakEvent event, ItemStack itemStack) { | ||
| } | ||
|
|
||
| default void onInventoryClicked(InventoryClickEvent event, ItemStack itemStack) { |
Collaborator
There was a problem hiding this comment.
Method name should match api's event name. No exceptions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should I just leave this in Draft until we depend on MC1.21? Since all of the enchantments will be semi-redone anyway with 1.21 enchantment system.