fix(portfolio): watchlist returns and four-column layout - #172
Merged
Conversation
Align holdings lookup keys for namespace codes (US:AAPL vs AAPL), show holding return when positions exist, apply market-aware trade fees, and recompute legacy US/HK trades on upgrade. Co-authored-by: Cursor <cursoragent@cursor.com>
…ist display Centralize return and holding PnL math in shared portfolio-return, align ETF identity and exchange vs NAV quotes, and sync portfolio tab with watchlist holdings refresh plus quote failure feedback. Co-authored-by: Cursor <cursoragent@cursor.com>
…aths Avoid pulling Node-only shared barrel modules into Vite by exporting portfolio-return and instrument-symbol entry points. Co-authored-by: Cursor <cursoragent@cursor.com>
Expand the right-panel watchlist into a scrollable four-column layout (price, follow return, cost, holding return), sync fuller stockindex names, and keep edit/delete controls pinned to the visible panel edge on hover without shadow. Co-authored-by: Cursor <cursoragent@cursor.com>
Travisun
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@opptrix/shared/portfolio-returnSSOTresolveDisplayStockNameTest plan
npm run check:ui