fix: watchlist quote reliability, portfolio InstrumentRef, and ETF cache - #177
Merged
Conversation
Make holdings/trades first-class InstrumentRef citizens with portfolio profiles, fund_quote routing, and collision-safe storage keys; batch and shard large watchlist realtime refreshes; consolidate application capability matrix in shared with ETF/JP/KR/CRYPTO rows. Co-authored-by: Cursor <cursoragent@cursor.com>
Exercise CN equity/ETF/FUND and HK equity with 52+ trades each, OTC fee overrides with recomputation, multi-holding summary, and PnL parity checks. Co-authored-by: Cursor <cursoragent@cursor.com>
…uote When live batch/single fetches fail, Hub now returns the last cached or in-process price instead of marking rows failed; CN watchlist realtime writes short-TTL cache and membership changes only invalidate added/removed symbols. Adds POST /api/instruments/quote, grace-period UX, and merge rules so rows with any valid price never show a failure state. Co-authored-by: Cursor <cursoragent@cursor.com>
addItemAndSync now prefetches fresh quotes for all add paths with addedPrice fallback; batch CN realtime writes per-symbol watchlist cache for stale recovery; watchlist save only invalidates removed symbols. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
npm run build:packagesnpm run check:uinode --test tests/watchlist-quote-prefetch.test.mjs tests/instrument-quote-stale-fallback.test.mjs tests/watchlist-quote-cache-merge.test.mjsMade with Cursor