tests(strnstr): add test 15. test finding the string when it exists i…#68
Open
douglasfanucchi wants to merge 2 commits into
Open
tests(strnstr): add test 15. test finding the string when it exists i…#68douglasfanucchi wants to merge 2 commits into
douglasfanucchi wants to merge 2 commits into
Conversation
…n haystack but the n bytes to lookup is a number greater than haystack length
Author
|
I just found other test cases that detects problems in that implementation, I'll be adding them to this PR later. |
…mpty and bytes to lookup is zero
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following ft_strnstr implementation passes in those 14 tests but it fails when trying to find a string that is present in the haystack and the n bytes to lookup is a number greater than the length of the haystack.
The test added in the pull request detects this problem in the above implementation.