Skip to content

Fix the bug exposed by Time_7 fault localization #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DehengYang wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix the bug exposed by Time_7 fault localization #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f7ca31
Update DataPreparer.java
DehengYang Jul 22, 2019
bdd74aa
Fix the bug exposed by Time_7 fault localization
DehengYang Jul 22, 2019
b1d62df
Fix the bug exposed by Time_7 fault localization
DehengYang Jul 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions FaultLocalization/src/main/java/edu/lu/uni/serval/dataprepare/DataPreparer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ public class DataPreparer {

private String buggyProjectParentPath;

public String bugDir; // the working directory for GZoltar.

public String classPath;
public String srcPath;
public String testClassPath;
Expand Down Expand Up @@ -62,6 +64,8 @@ private void loadPaths(String buggyProject) {
srcPath = projectDir + buggyProject + paths.get(2);
testSrcPath = projectDir + buggyProject + paths.get(3);

bugDir = projectDir + buggyProject; // set bugDir.

List<File> libPackages = new ArrayList<>();// dependencies.
if (new File(projectDir + buggyProject + "/lib/").exists()) {
libPaths.add(projectDir + buggyProject + "/lib/");
Expand Down
8 changes: 5 additions & 3 deletions FaultLocalization/src/main/java/edu/lu/uni/serval/faultlocalization/FL.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,9 @@ public class FL {
public static void main(String[] args) {
String outputPath = "GZoltar-0.1.1/" + Configuration.SUSPICIOUS_POSITIONS_FILE_APTH;
String path = Configuration.BUGGY_PROJECTS_PATH;
String projectName = "Chart_11";

// To run FL for Time_7.
String projectName = "Time_7";

log.info(projectName);

Expand Down Expand Up @@ -73,7 +75,7 @@ public void locateSuspiciousCode(String path, String buggyProject, String output
gzfl.srcPath = path + buggyProject + PathUtils.getSrcPath(buggyProject).get(2);

try {
gzfl.localizeSuspiciousCodeWithGZoltar(dp.classPaths, checkNotNull(Arrays.asList("")), dp.testCases);
gzfl.localizeSuspiciousCodeWithGZoltar(dp.bugDir, dp.classPaths, checkNotNull(Arrays.asList("")), dp.testCases);
} catch (NullPointerException e) {
for (String metricStr : Configuration.METRICS_0_1_1) {
FileHelper.outputToFile(outputPath + buggyProject + "/" + metricStr + ".txt", "", false);
Expand Down Expand Up @@ -136,7 +138,7 @@ public void locateSuspiciousCode(String path, String buggyProject, String output
gzfl.srcPath = path + buggyProject + PathUtils.getSrcPath(buggyProject).get(2);

try {
gzfl.localizeSuspiciousCodeWithGZoltar(dp.classPaths, checkNotNull(Arrays.asList("")), dp.testCases);
gzfl.localizeSuspiciousCodeWithGZoltar(dp.bugDir, dp.classPaths, checkNotNull(Arrays.asList("")), dp.testCases);
} catch (NullPointerException e) {
log.error(buggyProject + "\n" + e.getMessage());
e.printStackTrace();
Expand Down
14 changes: 12 additions & 2 deletions ...alization/src/main/java/edu/lu/uni/serval/faultlocalization/GZoltarFaultLoclaization.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public class GZoltarFaultLoclaization {
public List<String> failingTestCases = new ArrayList<String>();
public ArrayList<Statement> selectedSuspiciousStatements = new ArrayList<>();

public void localizeSuspiciousCodeWithGZoltar(final URL[] clazzPaths, Collection<String> packageNames, String... testClasses) throws NullPointerException {
public void localizeSuspiciousCodeWithGZoltar(String bugDir, final URL[] clazzPaths, Collection<String> packageNames, String... testClasses) throws NullPointerException {
ArrayList<String> classPaths = new ArrayList<String>();
StringBuilder b = new StringBuilder();
for (URL url : clazzPaths) {// Dependencies. lib
Expand All @@ -65,7 +65,13 @@ public void localizeSuspiciousCodeWithGZoltar(final URL[] clazzPaths, Collection
b.setLength(0);

try {
GZoltar gzoltar = new GZoltar(System.getProperty("user.dir"));
// Dale:
// the original code: new GZoltar(System.getProperty("user.dir"))
// will lead to unexpected failed test cases when localizing Time buggy projects,
// (e.g., this leads to the failure of org.joda.time.TestSerialization#testSerializedMutableDateTime when localizing Time_7.
// The failing detail includes: java.io.FileNotFoundException: src/test/resources/MutableDateTime.dat (No such file or directory)
// Therefore, the GZoltar working dir should be the bugDir, rather than the current FL project dir.
GZoltar gzoltar = new GZoltar(bugDir);

@Kui-Liu Kui-Liu Jul 22, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try this parameter setting for each Defects4J bug?
I remembered that I tried this parameter, it can throw some unexpected exceptions for some Defects4J bugs.

@DehengYang DehengYang Jul 22, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I have only studied the failure exposed by Time_7. In Time_7, it does not throw any exceptions, instead, the failure (i.e., the unexpected failed tests) needs to be examined manually (using Debugging or print statements).

And we can ensure that if GZoltar is not initialized with the buggy program directory, there will be also some Defectes4J bugs that may obtain many extra failed tests which use relative paths to test projects, just like org.joda.time.TestSerialization#testSerializedMutableDateTime in Time_7.

As you mentioned, if GZoltar is initialized with the buggy program directory, there will be some unexpected exceptions.

So... I think GZoltar 0.1.1 may have several bugs in itself, which has already negatively affected the accuracy of current fault localization. It is really necessary and highly demanded to implement GZoltar with java. （This can be an idea as well as a meaningful contribution for the APR and FL community).

Finally, maybe this pull request still needs/deserves more explorations/efforts.

Thank you again for your reply.


if (classPaths != null && !classPaths.isEmpty()) {
gzoltar.getClasspaths().addAll(classPaths);
Expand Down Expand Up @@ -277,6 +283,10 @@ private void parseTestResults() {
// } else {
// totalFailedTestCases ++;
// }

// to print the failed tests
System.out.println("The failed test case:" + tr.getName() + " " + tr.wasSuccessful());

if (!failingTestCases.contains(testName)) failingTestCases.add(testName);
}
}
Expand Down