Skip to content

Tested email analytics initializer - #29892

Merged
EvanHahn merged 10 commits into
data-db-typesfrom
email-analytics-init-di-and-test
Aug 13, 2026
Merged

Tested email analytics initializer#29892
EvanHahn merged 10 commits into
data-db-typesfrom
email-analytics-init-di-and-test

Conversation

@EvanHahn

@EvanHahn EvanHahn commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

no ref

I recommend reviewing this one commit at a time.

This change should have no user impact.

This change:

  • tests the email analytics initializer
  • stops using global references and injects the dependencies (DI)

In addition to automated testing, I also manually tested this. I sent a newsletter, opened it in Gmail, and verified that I saw the open appear in the newsletter's analytics.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 5c017d3a-d55f-4098-b7d1-f90af364d80c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Aug 11, 2026

Copy link
Copy Markdown

🤖 Nx Cloud AI Fix

Ensure the fix-ci command is configured to always run in your CI pipeline to get automatic fixes in future runs. For more information, please see https://nx.dev/ci/features/self-healing-ci


View your CI Pipeline Execution ↗ for commit cb47242

Command Status Duration Result
nx run ghost:test:integration ✅ Succeeded 3m 7s View ↗
nx run ghost:test:ci:integration ✅ Succeeded 5s View ↗
nx run ghost:test:legacy ✅ Succeeded 2m 57s View ↗
nx run ghost:test:e2e ✅ Succeeded 2m 39s View ↗
nx run-many -t test:unit -p ghost ✅ Succeeded 3s View ↗
nx run @tryghost/admin:build ✅ Succeeded 4s View ↗
nx run ghost-monorepo:lint:boundaries ✅ Succeeded <1s View ↗
nx run-many -t lint -p ghost,ghost-monorepo ✅ Succeeded 2s View ↗
nx run-many --target=build --projects=tag:publi... ✅ Succeeded <1s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-08-13 17:13:41 UTC

@codecov

codecov Bot commented Aug 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.00000% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.41%. Comparing base (e398296) to head (cb47242).

Files with missing lines Patch % Lines
...email-analytics/email-analytics-service-wrapper.js 74.41% 10 Missing and 1 partial ⚠️
...core/core/server/services/email-analytics/index.ts 98.11% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           data-db-types   #29892   +/-   ##
==============================================
  Coverage          75.40%   75.41%           
==============================================
  Files               1609     1609           
  Lines             142278   142368   +90     
  Branches           17610    17609    -1     
==============================================
+ Hits              107284   107363   +79     
- Misses             33920    33930   +10     
- Partials            1074     1075    +1     
Flag Coverage Δ
e2e-tests 77.45% <90.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@EvanHahn
EvanHahn requested a review from cmraible August 11, 2026 21:16
@EvanHahn
EvanHahn force-pushed the email-analytics-init-di-and-test branch from b769f91 to b1b974f Compare August 12, 2026 14:31
@EvanHahn
EvanHahn force-pushed the email-analytics-init-di-and-test branch 2 times, most recently from 2cb1471 to 0756337 Compare August 12, 2026 16:20
@EvanHahn
EvanHahn force-pushed the email-analytics-init-di-and-test branch from 0756337 to cb8a994 Compare August 13, 2026 16:27
@EvanHahn
EvanHahn force-pushed the email-analytics-init-di-and-test branch from cb8a994 to cb47242 Compare August 13, 2026 17:03
@EvanHahn
EvanHahn merged commit b23de25 into main Aug 13, 2026
57 of 86 checks passed
@EvanHahn
EvanHahn deleted the email-analytics-init-di-and-test branch August 13, 2026 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants