Skip to content

Trimmed cached c8 coverage artifacts - #30422

Merged
acburdine merged 1 commit into
mainfrom
claude/mysql-ghost-core-test-perf-fdc0f3
Sep 1, 2026
Merged

Trimmed cached c8 coverage artifacts#30422
acburdine merged 1 commit into
mainfrom
claude/mysql-ghost-core-test-perf-fdc0f3

Conversation

@acburdine

Copy link
Copy Markdown
Member

no ref

  • speed up acceptance tests runs by only caching the coverage xml artifact, rather than the full v8 profiles

no ref
- speed up acceptance tests runs by only caching the coverage xml artifact, rather than the full v8 profiles
@nx-cloud

nx-cloud Bot commented Sep 1, 2026

Copy link
Copy Markdown

🤖 Nx Cloud AI Fix

Ensure the fix-ci command is configured to always run in your CI pipeline to get automatic fixes in future runs. For more information, please see https://nx.dev/ci/features/self-healing-ci


View your CI Pipeline Execution ↗ for commit f47ec2c

Command Status Duration Result
nx run ghost:test:ci:integration ✅ Succeeded 4m 45s View ↗
nx run ghost:test:ci:e2e ✅ Succeeded 4m 28s View ↗
nx run ghost:test:legacy ✅ Succeeded 3m 33s View ↗
nx run-many -t test:unit -p ghost ✅ Succeeded 35s View ↗
nx run-many --target=build --projects=tag:publi... ✅ Succeeded <1s View ↗
nx run ghost-monorepo:lint:boundaries ✅ Succeeded <1s View ↗
nx run-many -t lint -p ghost ✅ Succeeded 21s View ↗
nx run @tryghost/admin:build ✅ Succeeded 7s View ↗
nx run @tryghost/e2e:test:fixtures ✅ Succeeded 1s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-09-01 13:26:57 UTC

@acburdine
acburdine force-pushed the claude/mysql-ghost-core-test-perf-fdc0f3 branch from f47ec2c to 32ad752 Compare September 1, 2026 13:14
@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: QUIET

Plan: Team

Run ID: dbd63411-77ee-419a-b35d-e0763c166627

📥 Commits

Reviewing files that changed from the base of the PR and between d65d61c and 32ad752.

📒 Files selected for processing (2)
  • ghost/core/.c8rc.e2e.json
  • ghost/core/package.json

Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (13)
  • GitHub Check: E2E Tests (Analytics 1/2)
  • GitHub Check: E2E Tests (Main 9/10)
  • GitHub Check: E2E Tests (Main 10/10)
  • GitHub Check: E2E Tests (Analytics 2/2)
  • GitHub Check: E2E Tests (Main 3/10)
  • GitHub Check: E2E Tests (Main 8/10)
  • GitHub Check: E2E Tests (Main 1/10)
  • GitHub Check: E2E Tests (Main 5/10)
  • GitHub Check: E2E Tests (Main 6/10)
  • GitHub Check: E2E Tests (Main 4/10)
  • GitHub Check: E2E Tests (Main 7/10)
  • GitHub Check: E2E Tests (Main 2/10)
  • GitHub Check: Acceptance tests (Node 22.23.1, mysql8)
🧰 Additional context used
📓 Path-based instructions (2)
Prioritise concrete correctness, security, data-integrity, compatibility,

⚙️ CodeRabbit configuration file

Files:

  • ghost/core/package.json
Always use `pnpm`, never npm or Yarn.

📄 CodeRabbit inference engine (AGENTS.md)

Files:

  • ghost/core/package.json
🔇 Additional comments (2)
ghost/core/.c8rc.e2e.json (1)

4-4: LGTM!

ghost/core/package.json (1)

387-387: LGTM!

Also applies to: 396-396


Walkthrough

The e2e coverage configuration now reports text summaries and Cobertura XML only. The test:ci:e2e and test:ci:integration Nx targets now reference their generated Cobertura XML files instead of coverage directories.

Suggested reviewers: 9larsons, evanhahn

Merge Risk: ⚪ Minimal · up to 32ad7

This change limits cached coverage artifacts to the XML report to speed acceptance-test runs; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Type-Safe Boundaries ✅ Passed PASS. The PR changes only .c8rc.e2e.json and package.json configuration. It removes the html-spa reporter and narrows Nx cache outputs to Cobertura XML files. It introduces no runtime boundary c…
New Files Are Typescript ✅ Passed The pull request modifies only ghost/core/.c8rc.e2e.json and ghost/core/package.json. The diff contains no added .js, .jsx, .cjs, or .mjs files.
Title check ✅ Passed The title clearly describes the main change: reducing cached c8 coverage artifacts.
Description check ✅ Passed The description explains that the change caches only the coverage XML artifact to speed up acceptance test runs.
Full details: Type-Safe Boundaries

Explanation

PASS. The PR changes only .c8rc.e2e.json and package.json configuration. It removes the html-spa reporter and narrows Nx cache outputs to Cobertura XML files. It introduces no runtime boundary consumption, schemas, casts, any, or TypeScript suppression. The custom check explicitly excludes configuration files.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/mysql-ghost-core-test-perf-fdc0f3

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.18%. Comparing base (d65d61c) to head (32ad752).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #30422      +/-   ##
==========================================
+ Coverage   76.14%   76.18%   +0.04%     
==========================================
  Files        1679     1679              
  Lines      160313   160313              
  Branches    19677    19686       +9     
==========================================
+ Hits       122073   122142      +69     
+ Misses      37214    37143      -71     
- Partials     1026     1028       +2     
Flag Coverage Δ
e2e-tests 77.85% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@acburdine
acburdine merged commit 4201aff into main Sep 1, 2026
52 checks passed
@acburdine
acburdine deleted the claude/mysql-ghost-core-test-perf-fdc0f3 branch September 1, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant