Skip to content

i18n: add missing pt translations for post share modal - #30507

Closed
joana-vieira-shape wants to merge 1 commit into
TryGhost:mainfrom
joana-vieira-shape:i18n/pt-portal-share-strings
Closed

i18n: add missing pt translations for post share modal#30507
joana-vieira-shape wants to merge 1 commit into
TryGhost:mainfrom
joana-vieira-shape:i18n/pt-portal-share-strings

Conversation

@joana-vieira-shape

Copy link
Copy Markdown

Fills in 4 blank strings in packages/i18n/locales/pt/portal.json that are used by Portal's post-share modal (share-modal.jsx): Share, Copy link, Copied, More options.

With a site's publication language set to pt, these specific strings were falling back to English while the rest of Portal (sign in, subscribe, account, etc.) was already translated — these were the only blank keys that screen actually calls via t().

@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: QUIET

Plan: Team

Run ID: 803667d5-69dd-419d-9651-0f5cc974f12a

📥 Commits

Reviewing files that changed from the base of the PR and between 5e04ede and 34af778.

📒 Files selected for processing (1)
  • packages/i18n/locales/pt/portal.json

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (1)
  • GitHub Check: Review translations
🧰 Additional context used
📓 Path-based instructions (4)
Review package boundaries and production consumption: minimal explicit exports, declared runtime dependencies, source-condition versus built-output parity, copied runtime assets, ESM/NodeNext compatibility, and consumer-facing release impac...

⚙️ CodeRabbit configuration file

Files:

  • packages/i18n/locales/pt/portal.json
Prioritise concrete correctness, security, data-integrity, compatibility, and regression risks.

⚙️ CodeRabbit configuration file

Files:

  • packages/i18n/locales/pt/portal.json
keep authored code in `src/**/*.ts` and tests in `test/**/*.ts`;

📄 CodeRabbit inference engine (packages/README.md)

Files:

  • packages/i18n/locales/pt/portal.json
Always use `pnpm`, never npm or Yarn.

📄 CodeRabbit inference engine (AGENTS.md)

Files:

  • packages/i18n/locales/pt/portal.json
🧠 Learnings (1)
📚 Learning: 2026-08-10T09:01:32.044Z
Learnt from: kevinansfield
Repo: TryGhost/Ghost PR: 29786
File: packages/i18n/locales/ru/ghost.json:93-93
Timestamp: 2026-08-10T09:01:32.044Z
Learning: When reviewing localization JSON files in packages/i18n/locales, do not report pre-existing translations that appear in the diff only because nearby added keys shifted their position. Report translation issues only when the translation itself was changed by the pull request, unless the review explicitly includes existing localization quality.

Applied to files:

  • packages/i18n/locales/pt/portal.json
🔇 Additional comments (1)
packages/i18n/locales/pt/portal.json (1)

80-82: LGTM!

Also applies to: 181-181, 228-228


Walkthrough

The Portuguese portal locale adds translations for “Copied”, “Copy link”, “More options”, and “Share”. The “Copy” entry remains untranslated.

Suggested reviewers: kevinansfield, sagzy, weylandswart

Merge Risk: ⚪ Minimal · up to 34af7

The Portuguese post-share modal labels now display localized text instead of English fallbacks, with no current merge-readiness risk.

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the locale update and the missing Portuguese translations for the post-share modal.
Description check ✅ Passed The description accurately explains the four Portuguese translations added to the Portal post-share modal and the English fallback issue.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Type-Safe Boundaries ✅ Passed PASS — The PR changes only packages/i18n/locales/pt/portal.json, a locale resource. The diff adds four string translations and introduces no HTTP/API/config/DB/event data handling, Zod-related type …
New Files Are Typescript ✅ Passed The PR changes only the pre-existing packages/i18n/locales/pt/portal.json file. The diff shows status M and no added .js, .jsx, .cjs, or .mjs source file.
Full details: Type-Safe Boundaries

Explanation

PASS — The PR changes only packages/i18n/locales/pt/portal.json, a locale resource. The diff adds four string translations and introduces no HTTP/API/config/DB/event data handling, Zod-related type changes, any, unchecked assertions, or TypeScript suppression directives. The check explicitly excludes config-like files and no stated failure condition applies.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌐 Automated translation review

Verdict:Looks good — no concerns flagged

Reviewed 4 translations across 1 file.

All four translations look excellent. "Copiado", "Copiar link", "Mais opções", and "Partilhar" are natural, accurate Portuguese equivalents that fit the share modal context perfectly, and they are consistent in register with the rest of the file. Obrigado!


Advisory review by i18n-review-bot. Non-blocking — a maintainer still owns the merge decision, and the bot cannot approve PRs on its own. Translator expertise wins where there is doubt.

@joana-vieira-shape

Copy link
Copy Markdown
Author

Closing — opened from the wrong GitHub account by mistake.

@joana-vieira-shape
joana-vieira-shape deleted the i18n/pt-portal-share-strings branch September 3, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant