Fixed broken pnpm/action-setup pin and excluded workspace file from zip#362
Conversation
The pnpm/action-setup digest ac6db6d3c1f721f886538a378a2d73e85697340a no longer exists upstream — GitHub returns HTTP 422 for it, so every workflow job using it fails to resolve the action. Replaced it with 0e279bb959325dab635dd2c09392533439d90093, the verified digest behind the current v6/v6.0.8 tag. This was discovered during the TryGhost/Themes pnpm migration, see TryGhost/Themes#529. Also excluded pnpm-workspace.yaml from the theme zip: it only carries pnpm 11 build-script approvals (development tooling) and doesn't belong in the installable theme package.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
WalkthroughThis PR updates pnpm tooling and configuration across the repository. The CI workflows in Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Summary
pnpm/action-setupdigestac6db6d3c1f721f886538a378a2d73e85697340awith0e279bb959325dab635dd2c09392533439d90093(the digest behind the currentv6/v6.0.8tag) in both workflows. The old digest no longer exists upstream — GitHub returns HTTP 422 for it, so any job using it fails to resolve the action. Discovered during the TryGhost/Themes pnpm migration (Changed package manager from yarn to pnpm Themes#529).'!pnpm-workspace.yaml'to the gulp-zip src glob exclusions ingulpfile.js. The file only carries pnpm 11 build-script approvals (development tooling) and doesn't belong in the installable theme zip.Verification
pnpm install --frozen-lockfile— lockfile up to date, install succeeded.pnpm zip— builtdist/massively.zipsuccessfully.unzip -l dist/massively.zip | grep -i pnpm— no matches; the zip contains no pnpm files (91 files total).gulpfile.js; no committed build output changed.