Skip to content

Fixed broken pnpm/action-setup pin and excluded workspace file from zip#362

Merged
aileen merged 1 commit into
mainfrom
fix-pnpm-action-pin-and-zip
Jun 10, 2026
Merged

Fixed broken pnpm/action-setup pin and excluded workspace file from zip#362
aileen merged 1 commit into
mainfrom
fix-pnpm-action-pin-and-zip

Conversation

@aileen

@aileen aileen commented Jun 10, 2026

Copy link
Copy Markdown
Member

Summary

  • Replaced the pnpm/action-setup digest ac6db6d3c1f721f886538a378a2d73e85697340a with 0e279bb959325dab635dd2c09392533439d90093 (the digest behind the current v6/v6.0.8 tag) in both workflows. The old digest no longer exists upstream — GitHub returns HTTP 422 for it, so any job using it fails to resolve the action. Discovered during the TryGhost/Themes pnpm migration (Changed package manager from yarn to pnpm Themes#529).
  • Added '!pnpm-workspace.yaml' to the gulp-zip src glob exclusions in gulpfile.js. The file only carries pnpm 11 build-script approvals (development tooling) and doesn't belong in the installable theme zip.

Verification

  • pnpm install --frozen-lockfile — lockfile up to date, install succeeded.
  • pnpm zip — built dist/massively.zip successfully.
  • unzip -l dist/massively.zip | grep -i pnpm — no matches; the zip contains no pnpm files (91 files total).
  • Diff is scoped to the two workflow files and gulpfile.js; no committed build output changed.

The pnpm/action-setup digest ac6db6d3c1f721f886538a378a2d73e85697340a no
longer exists upstream — GitHub returns HTTP 422 for it, so every workflow
job using it fails to resolve the action. Replaced it with
0e279bb959325dab635dd2c09392533439d90093, the verified digest behind the
current v6/v6.0.8 tag. This was discovered during the TryGhost/Themes pnpm
migration, see TryGhost/Themes#529.

Also excluded pnpm-workspace.yaml from the theme zip: it only carries pnpm 11
build-script approvals (development tooling) and doesn't belong in the
installable theme package.
@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5a1d668c-1d8b-4cb3-a71e-7a440bb55326

📥 Commits

Reviewing files that changed from the base of the PR and between 88cb7b2 and aa447c2.

📒 Files selected for processing (3)
  • .github/workflows/deploy-theme.yml
  • .github/workflows/test.yml
  • gulpfile.js

Walkthrough

This PR updates pnpm tooling and configuration across the repository. The CI workflows in .github/workflows/deploy-theme.yml and .github/workflows/test.yml both update the pnpm/action-setup GitHub Action to a newer pinned commit hash. Additionally, gulpfile.js is modified to exclude pnpm-workspace.yaml from the ZIP archive that packages the theme distribution, alongside the existing exclusion of pnpm-lock.yaml.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main changes: fixing a broken pnpm/action-setup pin and excluding a workspace file from the zip archive.
Description check ✅ Passed The description is directly related to the changeset, providing clear context about the broken digest issue and the workspace file exclusion from the zip.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-pnpm-action-pin-and-zip

Comment @coderabbitai help to get the list of available commands and usage tips.

@aileen aileen merged commit 84d6488 into main Jun 10, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant