Skip to content

Rebuilt JS assets in production mode#134

Merged
aileen merged 1 commit into
mainfrom
rebuild-production-assets
Jun 10, 2026
Merged

Rebuilt JS assets in production mode#134
aileen merged 1 commit into
mainfrom
rebuild-production-assets

Conversation

@aileen

@aileen aileen commented Jun 10, 2026

Copy link
Copy Markdown
Member

Summary

The committed assets/built/index.js on main was built in development mode — it begins with rollup-plugin-livereload's script-injection snippet, so every site running the Starter theme serves JS that tries to load a livereload server from the visitor's host on port 35729. Harmless-looking but wrong: a dev artifact shipped to production visitors on what is also the template repo people fork to build themes.

This rebuilds with the existing pnpm build (rollup --environment BUILD:production), which drops livereload and bundles only the theme code (burger menu, pagination/infinite scroll, etc.).

Found while fixing the pnpm action pin in #133.

Verification

  • grep livereload assets/built/index.js — 1 match before, 0 after
  • Two consecutive pnpm build runs produce identical output (deterministic)
  • pnpm test (gscan, with pretest zip) — no errors; the 4 warnings (twitter_url/facebook_url deprecations, custom fonts, @page.show_title_and_feature_image) are pre-existing on main
  • Diff is confined to assets/built/index.js + its sourcemap

The committed `assets/built/index.js` was produced by the development
build (`rollup --environment BUILD:development`): it began with the
livereload script-injection snippet, which every site using the Starter
theme shipped to visitors — attempting to load a livereload server from
the visiting host on port 35729. Rebuilt with `pnpm build` (production
mode), which drops the livereload plugin and bundles only the theme
code. Verified the rebuild is deterministic and gscan reports no errors
(4 pre-existing warnings unrelated to this change).

Found while fixing the pnpm action pin (#133).
@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@aileen, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 10 minutes. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7bd54929-c0d8-477f-b62a-05189cbda965

📥 Commits

Reviewing files that changed from the base of the PR and between ed1bb93 and 97b3e93.

⛔ Files ignored due to path filters (1)
  • assets/built/index.js.map is excluded by !**/*.map
📒 Files selected for processing (1)
  • assets/built/index.js
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch rebuild-production-assets

Comment @coderabbitai help to get the list of available commands and usage tips.

@aileen aileen merged commit a616c7d into main Jun 10, 2026
5 checks passed
@aileen aileen deleted the rebuild-production-assets branch June 10, 2026 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant