Skip to content

Rebuild themes: ship pending it/tr/vi translations#524

Merged
9larsons merged 1 commit into
mainfrom
ship-pending-translations
Jun 4, 2026
Merged

Rebuild themes: ship pending it/tr/vi translations#524
9larsons merged 1 commit into
mainfrom
ship-pending-translations

Conversation

@9larsons

@9larsons 9larsons commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

What

Rebuilds all 16 themes so the pending translation updates actually ship. A fresh `yarn build` on `main` produces an 81-file diff — this PR is that rebuild.

Why

Shared inputs were bumped without rebuilding the themes, so committed built output drifted from source:

  • theme-translations 0.0.19 → 0.0.21 added Italian (new locale), Turkish, and Vietnamese strings. Themes currently ship empty strings for these (e.g. Turkish "Access code": """Erişim kodu"). Italian (it.json) is added to every theme for the first time.
  • cssnano → v8 (chore(deps): update dependency cssnano to v8 #507) regenerates screen.css with reordered declarations — identical CSS, no functional/visual change, just different minified bytes.

This is the manual "rebuild after a shared change" step that nothing currently enforces (the subject of the CD RFC under review).

Validation

  • gscan: all 16 themes pass (Ghost 6.x compatible).
  • CSS changes are declaration-reordering only (verified via word-diff).

Effect on merge

Each theme's deploy + subtree workflow fires, shipping the translations to the standalone repos and demo sites.

theme-translations was bumped to 0.0.21 (it/tr/vi strings) and cssnano to
v8 (#507) without rebuilding themes, so built output drifted from source.

- Propagates Italian, Turkish and Vietnamese locale updates into all 16
  themes (they currently ship empty strings for these)
- Regenerates screen.css under cssnano v8 — declaration reordering only,
  no functional or visual change
- gscan: all themes pass (Ghost 6.x compatible)
@coderabbitai

coderabbitai Bot commented Jun 4, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

Walkthrough

This PR adds Italian locale translations to multiple theme packages, completes Turkish translations for authentication and subscription UI strings across all themes, updates Vietnamese locale wording for navigation and recommendation labels, and regenerates minified CSS stylesheets across ten theme packages (alto, bulletin, dawn, digest, dope, ease, edge, edition, episode, headline, journal). All changes are distributed consistently across the same set of packages, with no modifications to code logic or exported APIs.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • TryGhost/Themes#504: Updates Vietnamese locale values for the same UI keys (More links, Next issue, Next post, Recommendations) across the same vi.json files.
  • TryGhost/Themes#510: Turkish locale updates mirror missing string translations being filled in tr.json files for the same keys (access codes, validation messages, signup restrictions, "Too many sign-up attempts…").
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main purpose of the PR: rebuilding themes to include pending Italian, Turkish, and Vietnamese translations.
Description check ✅ Passed The description comprehensively explains the context, rationale, validation, and impact. It details the shared dependency updates (theme-translations and cssnano), the changes to locale files across 16 themes, CSS regeneration details, and testing results.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ship-pending-translations

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@9larsons 9larsons merged commit e5906c1 into main Jun 4, 2026
51 of 52 checks passed
@9larsons 9larsons deleted the ship-pending-translations branch June 4, 2026 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant