Skip to content

Removed package-local Renovate preset from theme-translations#528

Merged
aileen merged 1 commit into
mainfrom
remove-local-renovate-config
Jun 10, 2026
Merged

Removed package-local Renovate preset from theme-translations#528
aileen merged 1 commit into
mainfrom
remove-local-renovate-config

Conversation

@aileen

@aileen aileen commented Jun 10, 2026

Copy link
Copy Markdown
Member

The translation auto-merge rule for @tryghost/theme-translations has officially moved into the shared theme preset in TryGhost/renovate-config (theme.json5), and no theme repository extends the package-local renovate-config.json anymore.

This removes the now-unused local preset:

  • Deleted packages/theme-translations/renovate-config.json
  • Dropped it from the published files list in package.json
  • Removed the README references, including the migration TODO that tracked this cleanup

The shared theme preset is now the single source of truth for Renovate rules.

Verified with npm test in packages/theme-translations (all tests pass).

The translation auto-merge rule now ships as part of the shared theme preset in `TryGhost/renovate-config` (`theme.json5`), and no theme repository extends the package-local `renovate-config.json` anymore. Deleted the file, dropped it from the published `files` list in `package.json`, and removed the README references including the migration TODO, so the shared preset is the single source of truth for Renovate rules going forward.
@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 60dd4636-7553-4833-b005-c845ae113c90

📥 Commits

Reviewing files that changed from the base of the PR and between f66a902 and 755f132.

📒 Files selected for processing (3)
  • packages/theme-translations/README.md
  • packages/theme-translations/package.json
  • packages/theme-translations/renovate-config.json
💤 Files with no reviewable changes (1)
  • packages/theme-translations/renovate-config.json

Walkthrough

This PR removes the package-local renovate-config.json file from the theme-translations package. The changes include updating the files whitelist in package.json to exclude the configuration file from published distributions, removing the file entry from the README contents section, and condensing the Renovate auto-merge documentation note by removing references to the deprecated local configuration preset.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removal of the package-local Renovate preset from theme-translations, which aligns with all file modifications.
Description check ✅ Passed The description is directly related to the changeset, providing clear context about why the Renovate config was removed and documenting the specific changes made.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch remove-local-renovate-config

Comment @coderabbitai help to get the list of available commands and usage tips.

@aileen aileen merged commit 104c741 into main Jun 10, 2026
53 of 54 checks passed
@aileen aileen deleted the remove-local-renovate-config branch June 10, 2026 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant