CST1229/zip: don't use regex for data validation#2440
Merged
CubesterYT merged 2 commits intoTurboWarp:masterfrom Mar 18, 2026
Merged
CST1229/zip: don't use regex for data validation#2440CubesterYT merged 2 commits intoTurboWarp:masterfrom
CubesterYT merged 2 commits intoTurboWarp:masterfrom
Conversation
github-actions
Bot
added
the
pr: change existing extension
Contributor
Author
|
!format |
CST1229
approved these changes
Mar 18, 2026
Collaborator
|
right the review template exists
|
CubesterYT
approved these changes
Mar 18, 2026
Member
CubesterYT
left a comment
CubesterYT
left a comment
There was a problem hiding this comment.
- I tested all modified functionality and found no bugs or unintuitive behavior.
- I believe a well-formed project using an older version of this extension will not be broken by this new version.
- I have no additional concerns.
|
Woah, I'm shocked at how quickly this actually got fixed, that's incredible. Appreciate everything y'all do |
Contributor
cough cough it's not normally this fast, you should be shocked |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this should resolve #2439