bezier - Fix z value computation - #3042
Conversation
mfedderly
left a comment
There was a problem hiding this comment.
I think that this is probably a correct fix for the z values, but the package itself only spits out 2d coordinates meaning that I don't think this impacts the output of the package.
Are you trying to use this package for 3d work?
|
Note to self: the original version of this code appears to be also broken and it lives at https://github.com/dowrow/bezier-spline-js/blob/master/bezier-spline.js |
I just want the code to be correct even when the z value is not used, to avoid other potential unknown errors. I discovered this issue while studying how Bézier curves are calculated. |
Fix the issue of incorrect variable reference in the assignment of const dz on line 74 of the packages/turf-bezier-spline/lib/spline.ts file.