Invalidate stale bboxes in coordinate mutators - #3108
Draft
khalilurrrahmanridoykhan wants to merge 2 commits into
Draft
Invalidate stale bboxes in coordinate mutators#3108khalilurrrahmanridoykhan wants to merge 2 commits into
khalilurrrahmanridoykhan wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
bboxvalues recursively afterflip,toMercator,toWgs84, andtruncatechange coordinatesmutate: trueWhy
These functions change coordinate positions but retained cached bounding boxes describing the pre-mutation geometry. A later bbox lookup could therefore return stale coordinates. This follows the behavior established in #3106 and reuses the recursive
removeBboxhelper introduced there.Validation
pnpm --filter @turf/flip test— 9 passedpnpm --filter @turf/projection test— 52 passedpnpm --filter @turf/truncate test— 17 passedgit diff --check