Clarify geomEach behavior and add a test - #3112
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
geomEachactually has some strange behavior when operating on nested GeometryCollections. It will unwrap twice (root GeometryCollection with a nested GeometryCollection) or just once (Feature containing a GeometryCollection). It does not infinitely recurse.The RFC states:
So I'm not sure if anyone is really expecting this to work in practice, but for now lets just add a warning to the docs and add a test demonstrating the behavior so we don't accidentally break things here.
I'd be open to changing the functionality in the future if someone feels like this should be improved. In general the methods in meta seem like they require a lot of focus to work on and make sure that performance isn't regressed. A lot of the rest of Turf depends on them to be as fast as possible. I'm not sure we've visited the benchmarks with modern JS engines though, and I'd like the typings to get more strict to help in other packages.