Skip to content

Remove FillArrays dep#202

Merged
penelopeysm merged 2 commits intomainfrom
py/nofill
Apr 6, 2026
Merged

Remove FillArrays dep#202
penelopeysm merged 2 commits intomainfrom
py/nofill

Conversation

@penelopeysm
Copy link
Copy Markdown
Member

@penelopeysm penelopeysm commented Apr 6, 2026

Closes #131. The only place where Fill was being used was Fill(nothing, nchains), and given that fill(nothing, N) really takes up no space, I don't think it's necessary to micro-optimise it away, so the dep can be removed.

FillArrays is still a test dep. Although I find this to also be quite needless, I don't see any harm in keeping it, so it stays.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 6, 2026

AbstractMCMC.jl documentation for PR #202 is available at:
https://TuringLang.github.io/AbstractMCMC.jl/previews/PR202/

@penelopeysm penelopeysm merged commit ee61477 into main Apr 6, 2026
15 checks passed
@penelopeysm penelopeysm deleted the py/nofill branch April 6, 2026 18:09
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (237025c) to head (21f40fe).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff     @@
##   main   #202   +/-   ##
===========================
===========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Maybe clean up dependence on FillArrays.jl?

1 participant