Skip to content

TT-18255 replace old jira linter with github action - #452

Merged
rafalgolarz merged 1 commit into
masterfrom
TT-18255_replace_old_jira_linter_with_github_action
Sep 8, 2026
Merged

TT-18255 replace old jira linter with github action#452
rafalgolarz merged 1 commit into
masterfrom
TT-18255_replace_old_jira_linter_with_github_action

Conversation

@rafalgolarz

@rafalgolarz rafalgolarz commented Sep 8, 2026

Copy link
Copy Markdown

Ticket Details

TT-18255
Status In Dev
Summary Replace TykTechnologies/jira-linter with TykTechnologies/github-actions

Generated at: 2026-09-08 13:12:17

@rafalgolarz rafalgolarz self-assigned this Sep 8, 2026
@probelabs

probelabs Bot commented Sep 8, 2026

Copy link
Copy Markdown

This PR updates the GitHub Actions workflow responsible for validating Jira tickets in pull request titles. It replaces the previous TykTechnologies/jira-linter@main action with a new, centralized action from TykTechnologies/github-actions/jira-linter@production. This change standardizes the CI/CD process by using a reusable action. Additionally, the configuration is updated to use new repository secrets (JIRA_BASE_URL, JIRA_READ_AUTH) for authentication, enhancing security and consistency.

Files Changed Analysis

  • File: .github/workflows/jira-pr-validator.yaml
  • Status: Modified
  • Changes: 3 additions, 4 deletions
  • Summary: The changes are confined to a single GitHub Actions workflow file. The core modification is swapping the uses directive to point to a new action and updating the corresponding input parameters and secrets.

Architecture & Impact Assessment

  • What this PR accomplishes: It standardizes the Jira ticket validation process by migrating from a standalone linter to a centralized, reusable GitHub Action. This improves maintainability and ensures consistency across different repositories.
  • Key technical changes introduced:
    • The uses directive in the workflow is changed from TykTechnologies/jira-linter@main to TykTechnologies/github-actions/jira-linter@production.
    • The authentication parameter jira-api-token is replaced with jira-read-auth.
    • The hardcoded jira-base-url is now sourced from the secrets.JIRA_BASE_URL secret.
  • Affected system components: The change affects the repository's CI/CD pipeline, specifically the pull request validation step. There is no impact on the runtime application. Developers will rely on this updated workflow to ensure their PRs meet contribution guidelines.
graph TD
    subgraph "Before"
        A[PR Event] --> B(jira-pr-validator.yaml);
        B --> C["uses: TykTechnologies/jira-linter@main"];
        C --> D{Jira API};
    end
    subgraph "After"
        E[PR Event] --> F(jira-pr-validator.yaml);
        F --> G["uses: TykTechnologies/github-actions/jira-linter@production"];
        G --> H{Jira API};
    end

Loading

Scope Discovery & Context Expansion

  • Broader Context: This change is likely part of a larger, organization-wide effort to consolidate and standardize CI/CD tooling into a central github-actions repository. This promotes reuse, versioning, and easier maintenance of common workflows.
  • Further Exploration (if tools were available):
    • Search: I would search across the organization's repositories for other instances of TykTechnologies/jira-linter to identify other workflows that need to be updated.
    • Verify: I would confirm that the required secrets (JIRA_BASE_URL, JIRA_READ_AUTH) have been configured in this repository's GitHub secrets settings.
    • Inspect: I would examine the TykTechnologies/github-actions repository to understand the implementation and other features of the new jira-linter action.
Metadata
  • Review Effort: 1 / 5
  • Primary Label: chore

Powered by Visor from Probelabs

Last updated: 2026-09-08T13:12:46.223Z | Triggered by: pr_opened | Commit: 3b14401

💡 TIP: You can chat with Visor using /visor ask <your question>

@probelabs

probelabs Bot commented Sep 8, 2026

Copy link
Copy Markdown

Architecture Issues (1)

Severity Location Issue
🟡 Warning .github/workflows/jira-pr-validator.yaml:17
The GitHub Action is pinned to `@production`, which is a mutable reference. While better than `@main`, using a floating tag can introduce unexpected behavior or breaking changes if the underlying commit changes. For deterministic and secure builds, it is best practice to pin actions to a specific, immutable commit SHA.
💡 SuggestionReplace the `@production` tag with the full commit SHA that the tag currently points to. This ensures that the workflow will always use the exact same version of the action, preventing unexpected failures or security vulnerabilities from upstream changes.

✅ Performance Check Passed

No performance issues found – changes LGTM.

\n\n

Architecture Issues (1)

Severity Location Issue
🟡 Warning .github/workflows/jira-pr-validator.yaml:17
The GitHub Action is pinned to `@production`, which is a mutable reference. While better than `@main`, using a floating tag can introduce unexpected behavior or breaking changes if the underlying commit changes. For deterministic and secure builds, it is best practice to pin actions to a specific, immutable commit SHA.
💡 SuggestionReplace the `@production` tag with the full commit SHA that the tag currently points to. This ensures that the workflow will always use the exact same version of the action, preventing unexpected failures or security vulnerabilities from upstream changes.
\n\n ### ✅ Performance Check Passed

No performance issues found – changes LGTM.

\n\n

✅ Quality Check Passed

No quality issues found – changes LGTM.


Powered by Visor from Probelabs

Last updated: 2026-09-08T13:12:45.195Z | Triggered by: pr_opened | Commit: 3b14401

💡 TIP: You can chat with Visor using /visor ask <your question>

@sonarqubecloud

sonarqubecloud Bot commented Sep 8, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@rafalgolarz
rafalgolarz merged commit ace9e84 into master Sep 8, 2026
11 checks passed
@rafalgolarz
rafalgolarz deleted the TT-18255_replace_old_jira_linter_with_github_action branch September 8, 2026 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants