Skip to content

Merging to release-5.13: Improve clarity for legacy session lifetime management (#2985) - #2988

Merged
probelabs[bot] merged 1 commit into
release-5.13from
merge/release-5.13/f193b70dab6ec1a16d9429be178649d0a2f6a8df
Sep 9, 2026
Merged

Merging to release-5.13: Improve clarity for legacy session lifetime management (#2985)#2988
probelabs[bot] merged 1 commit into
release-5.13from
merge/release-5.13/f193b70dab6ec1a16d9429be178649d0a2f6a8df

Conversation

@probelabs

@probelabs probelabs Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

User description

Improve clarity for legacy session lifetime management (#2985)


PR Type

Documentation


Description

  • Clarify legacy session fallback conditions

  • Document grace period activation rules

  • Explain zero-grace retained session behavior


Diagram Walkthrough

flowchart LR
  old["Older Tyk version"]
  unset["post_expiry_action unset"]
  retain0["retain with zero grace"]
  legacy["Legacy controls"]
  grace["Grace period applies only with retain"]

  old -- "falls back to" --> legacy
  unset -- "falls back to" --> legacy
  retain0 -- "falls back to" --> legacy
  unset -- "clarifies" --> grace
Loading

File Walkthrough

Relevant files
Documentation
session-lifecycle.mdx
Clarify legacy session expiry fallback behavior                   

api-management/access-control/sessions-and-keys/session-lifecycle.mdx

  • List three legacy fallback scenarios
  • Clarify post_expiry_action dependency
  • Document zero-grace retain fallback
  • Preserve OAuth retention reference formatting
+6/-2     

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ✅

2985 - Fully compliant

Compliant requirements:

  • Clarify the legacy session lifecycle fallback conditions.
  • Explain how post_expiry_action and post_expiry_grace_period interact.
  • Enumerate the three scenarios where Tyk falls back to legacy controls.
  • Clarify that post_expiry_grace_period only takes effect when the action is set appropriately.
  • Document the zero-grace behavior when sessions are retained.
⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

@probelabs
probelabs Bot merged commit 4f19522 into release-5.13 Sep 9, 2026
3 checks passed
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

PR Code Suggestions ✨

No code suggestions found for the PR.

@probelabs
probelabs Bot deleted the merge/release-5.13/f193b70dab6ec1a16d9429be178649d0a2f6a8df branch September 9, 2026 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant