One complex parameter should count as two params#193
Open
scaomath wants to merge 3 commits intoTylerYep:mainfrom
Open
One complex parameter should count as two params#193scaomath wants to merge 3 commits intoTylerYep:mainfrom
scaomath wants to merge 3 commits intoTylerYep:mainfrom
Conversation
Owner
|
Thanks for looking into this. Could you provide a small example model + output to illustrate your point? That will help validate this fix works |
Author
I added a test. Complex layer correctly returns the double params count. I encounter this issue when running torchinfo for network like FNO: neuraloperator/neuraloperator#52 Thoughts? @TylerYep |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As all models' parameters counting traces back here
torchinfo/torchinfo/layer_info.py
Lines 154 to 170 in 8b3ae72
there is no checking on whether the parameter tensor is complex or real. If a parameter is complex, such as
a + i b, then it represents actually two parameters (for counting MACs/FLOPs purpose).Of course this PR might not be conforming with
torchinfo's dev, feel free to close it, I hope complex would be considered in next version.