Fixing #371 and tried adding directml support #368#376
Open
ChanifRusydi wants to merge 5 commits intoTylerYep:mainfrom
Open
Fixing #371 and tried adding directml support #368#376ChanifRusydi wants to merge 5 commits intoTylerYep:mainfrom
ChanifRusydi wants to merge 5 commits intoTylerYep:mainfrom
Conversation
Author
|
Local testing on Apple Silicon based mac (MPS) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is heavily inspired by #370 to fix #371 . I didn't have AMD GPU at hand, but this PR attempting to address #358. And yes this is quite janky.
The DirectML implementation is solely based on the following documentation and example:
https://github.com/microsoft/DirectML
https://medium.com/@ochwada/preparations-for-pytorch-and-directml-on-amd-ryzen-9-6950h-for-ai-projects-15c164d22332