Skip to content

Playwright fixes and non-public tests#978

Closed
dw-ukhsa wants to merge 50 commits into
feature/CDD-2509-playwright-test-non-publicfrom
test/add-logging-to-auth-fixture
Closed

Playwright fixes and non-public tests#978
dw-ukhsa wants to merge 50 commits into
feature/CDD-2509-playwright-test-non-publicfrom
test/add-logging-to-auth-fixture

Conversation

@dw-ukhsa

@dw-ukhsa dw-ukhsa commented Jun 17, 2026 •
edited
Loading

Copy link
Copy Markdown

Description

Fixes #CDD-

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Unit tests
  • Playwright e2e tests
  • Mobile responsiveness
  • Accessibility (i.e. Lighthouse audit)
  • Disabled JavaScript

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • Any styles in this change follow the 'STYLES.md' guide
  • My changes are progressively enhanced with graceful degredagation for older browsers and non-JavaScript users
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@github-actions

github-actions Bot commented Jun 17, 2026 •
edited
Loading

Copy link
Copy Markdown

Unit tests coverage

Lines Statements Branches Functions
Coverage: 96%
 94.83% (4623/4875) 84.66% (1491/1761) 95.29% (850/892)
Tests Skipped Failures Errors Time
1729 0 💤 0 ❌ 0 🔥 30.03s ⏱️

dw-ukhsa and others added 24 commits June 18, 2026 15:07
@dw-ukhsa
Merge branch 'feature/CDD-2509-playwright-test-non-public' of github.…
f30e9fd 
…com:UKHSA-Internal/data-dashboard-frontend into test/add-logging-to-auth-fixture
@dw-ukhsa
Merge branch 'feature/CDD-2509-playwright-test-non-public' of github.…
27860f7 
…com:UKHSA-Internal/data-dashboard-frontend into test/add-logging-to-auth-fixture
@dw-ukhsa
adding debugging to tests
f4852d7
@dw-ukhsa
Moving logout banner check to part of start page -logged out test block
cbd13c0
@dw-ukhsa
adding more alert logging
8ffdaaa
@dw-ukhsa
Merge branch 'feature/CDD-2509-playwright-test-non-public' into test/…
3462c72 
…add-logging-to-auth-fixture
@dw-ukhsa
yet more logging
bf3b140
@dw-ukhsa
Merge branch 'test/add-logging-to-auth-fixture' of github.com:UKHSA-I…
50f50ad 
…nternal/data-dashboard-frontend into test/add-logging-to-auth-fixture
@dw-ukhsa
correcting syntax issue
dc15b3d
@dw-ukhsa
Updating auth fixture to find logout banner more accurately
289e080
@dw-ukhsa
introducing e2e tests for non-public
097dc5e
@dw-ukhsa
Adding @auth-ui tagging to tests so CI can pick them up correctly
ef02021
@dw-ukhsa
Adding covid test fic=xture for classification banner with public test
a1e1ebe
@dw-ukhsa
Removing irrelevant non-public tests
1a0efc6
@dw-ukhsa
removing un-used includes as causing linting issue
4109cb8
@dw-ukhsa
Adding a non-public COVID-19 test file
98137d8
@manubinary
CDD-2509
55c8396 
The auth fixture is refactored
e2e-tests-non-public - enabled
@dw-ukhsa
Refactor of tests to check for classification banner
35622a5
@manubinary
Update app.fixture.non.public.ts
47c4cc5 
disable eslint rules for noon-puublic
@manubinary
wrong file updated
ee27080 
wrong file updated
@dw-ukhsa
Tricking sonarqube into letting tests through so I can check progress
e85ed95
@dw-ukhsa
Adding banner fixtures back into auth-start fixture
ebb6ece
@dw-ukhsa
Adding checkClassificationBannerContent to all app classes
68ceb61
@dw-ukhsa
trying to hook changing is_public in, in a simplified way
1d8d8d1
dw-ukhsa and others added 17 commits June 23, 2026 09:49
@dw-ukhsa
Another attempt at setting the is_public flag
ab0eed5
@manubinary
Update eslint.config.mjs
454e256
@manubinary
Update eslint.config.mjs
4ed82bc
@dw-ukhsa
adding BASE_URL to env to prevent wrong isWellKnownEnviornment() logic
5771d1c
@manubinary
Update eslint.config.mjs
f8d75a8
@dw-ukhsa
Adding explicit click to radio buttons while changing isPublic state
df74080
@dw-ukhsa
Switching test for classification banner to be more specific
4bb3caa
@dw-ukhsa
Removing console.logs
3302792
@dw-ukhsa
removing un-used variable
d97cf7d
@dw-ukhsa
Merge branch 'feature/CDD-2509-playwright-test-non-public' of github.…
32567b7 
…com:UKHSA-Internal/data-dashboard-frontend into test/add-logging-to-auth-fixture
@dw-ukhsa
reverting 'provide' in places of 'use' to test linting rules
094b702
@manubinary
unwanted commit reverted
dd45a1f 
unwanted commit reverted
@dw-ukhsa
Reintroducing 'broken' code to check source of issues
205813e
@dw-ukhsa
Adding a .sonarcloud.properties file
7b279f8
@dw-ukhsa
trying broaded sonar config incase issues weren't caught
b16e989
@manubinary
Create .sonarcloud.properties
f0d713e
@manubinary
Merge branch 'feature/CDD-2509-playwright-test-nonPublic' into test/a…
b51fea7 
…dd-logging-to-auth-fixture
@dw-ukhsa dw-ukhsa changed the title Experimental: test PR for debugging Playwright fixes and non-public tests Jun 24, 2026
@dw-ukhsa dw-ukhsa marked this pull request as ready for review June 24, 2026 06:49
@dw-ukhsa dw-ukhsa requested a review from a team as a code owner June 24, 2026 06:49
@dw-ukhsa dw-ukhsa closed this Jun 24, 2026
@sonarqubecloud

sonarqubecloud Bot commented Jun 24, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manubinary manubinary manubinary left review comments
@mattjreynolds mattjreynolds mattjreynolds left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dw-ukhsa @manubinary @mattjreynolds