Skip to content

Test/add logging to auth fixture#987

Merged
manubinary merged 124 commits into
feature/CDD-2509-playwright-test-nonPublicfrom
test/add-logging-to-auth-fixture
Jun 24, 2026
Merged

Test/add logging to auth fixture#987
manubinary merged 124 commits into
feature/CDD-2509-playwright-test-nonPublicfrom
test/add-logging-to-auth-fixture

Conversation

@manubinary

@manubinary manubinary commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes #CDD-

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Unit tests
  • Playwright e2e tests
  • Mobile responsiveness
  • Accessibility (i.e. Lighthouse audit)
  • Disabled JavaScript

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • Any styles in this change follow the 'STYLES.md' guide
  • My changes are progressively enhanced with graceful degredagation for older browsers and non-JavaScript users
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

manubinary added 30 commits May 18, 2026 10:38
@manubinary
The auth fixture is refactored
dd7ffa6 
The auth fixture is refactored
@manubinary
Update auth-setup.fixture.ts
7f192f5 
for passing sonarqube quality gate
@manubinary
enable e2e test for non public
56bccb6 
enable e2e test for non public
@manubinary
Update build-test-deploy.yml
1bd6fb3
@manubinary
Update build-test-deploy.yml
d825e95
@manubinary
Update build-test-deploy.yml
044f3f4
@manubinary
Update build-test-deploy.yml
0a624a8
@manubinary
The cache key is based on file hashes
9daf0df
@manubinary
Update build-test-deploy.yml
c0535b6
@manubinary
Update build-test-deploy.yml
ee83ead
@manubinary
Update auth-setup.fixture.ts
152dfbf
@manubinary
Update build-test-deploy.yml
31b1711
@manubinary
Update auth.ts
d9419a1
@manubinary
Update build-test-deploy.yml
5bf0742
@manubinary
test issue fix
2f5f4f6
@manubinary
non public test fix
8900532
@manubinary
Non public test enabled
dd6f825
@manubinary
Update build-test-deploy.yml
d9a3601
@manubinary
Update build-test-deploy.yml
23a777f
@manubinary
Update auth-setup.fixture.ts
bdc5c0d
@manubinary
code revert
6aad8ce
@manubinary
Update build-test-deploy.yml
68002bd
@manubinary
Update build-test-deploy.yml
2905e28
@manubinary
Update build-test-deploy.yml
873a07a
@manubinary
Update build-test-deploy.yml
6d73141
@manubinary
non public test fix
0d25787 
non public test fix
@manubinary
Update build-test-deploy.yml
986dea5
@manubinary
Update build-test-deploy.yml
d658b6b
@manubinary
Update build-test-deploy.yml
4a3c570
@manubinary
Update build-test-deploy.yml
1164779
dw-ukhsa and others added 19 commits June 22, 2026 10:48
@dw-ukhsa
removing un-used includes as causing linting issue
4109cb8
@manubinary
Merge branch 'main' into feature/CDD-2509-playwright-test-non-public
2095f39
@dw-ukhsa
Adding a non-public COVID-19 test file
98137d8
@dw-ukhsa
Refactor of tests to check for classification banner
35622a5
@dw-ukhsa
Tricking sonarqube into letting tests through so I can check progress
e85ed95
@dw-ukhsa
Adding banner fixtures back into auth-start fixture
ebb6ece
@dw-ukhsa
Adding checkClassificationBannerContent to all app classes
68ceb61
@dw-ukhsa
trying to hook changing is_public in, in a simplified way
1d8d8d1
@dw-ukhsa
Another attempt at setting the is_public flag
ab0eed5
@dw-ukhsa
adding BASE_URL to env to prevent wrong isWellKnownEnviornment() logic
5771d1c
@dw-ukhsa
Adding explicit click to radio buttons while changing isPublic state
df74080
@dw-ukhsa
Switching test for classification banner to be more specific
4bb3caa
@dw-ukhsa
Removing console.logs
3302792
@dw-ukhsa
removing un-used variable
d97cf7d
@dw-ukhsa
Merge branch 'feature/CDD-2509-playwright-test-non-public' of github.…
32567b7 
…com:UKHSA-Internal/data-dashboard-frontend into test/add-logging-to-auth-fixture
@dw-ukhsa
reverting 'provide' in places of 'use' to test linting rules
094b702
@dw-ukhsa
Reintroducing 'broken' code to check source of issues
205813e
@dw-ukhsa
Adding a .sonarcloud.properties file
7b279f8
@dw-ukhsa
trying broaded sonar config incase issues weren't caught
b16e989
@manubinary manubinary requested a review from a team as a code owner June 23, 2026 16:06
@github-actions

github-actions Bot commented Jun 23, 2026 •
edited
Loading

Copy link
Copy Markdown

Unit tests coverage

Lines Statements Branches Functions
Coverage: 96%
 94.83% (4623/4875) 84.66% (1491/1761) 95.29% (850/892)
Tests Skipped Failures Errors Time
1729 0 💤 0 ❌ 0 🔥 29.134s ⏱️

@manubinary manubinary merged commit 2d46266 into feature/CDD-2509-playwright-test-nonPublic Jun 24, 2026
31 of 32 checks passed
@sonarqubecloud

sonarqubecloud Bot commented Jun 24, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dw-ukhsa dw-ukhsa dw-ukhsa approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@manubinary @dw-ukhsa