Skip to content

faet: [ASL-4650] Upgrade docx package to version 9.5.3 and update related imports #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kiran-varma-home-office wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

faet: [ASL-4650] Upgrade docx package to version 9.5.3 and update related imports #380

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
270b8e5
Upgrade docx package to version 9.5.3 and update related imports
kiran-varma-home-office Feb 17, 2026
658e0c5
Merge branch 'main' into feat/asl-4650-update-docx
kiran-varma-home-office Mar 18, 2026
5685131
Merge branch 'main' into feat/asl-4650-update-docx
kiran-varma-home-office Mar 18, 2026
7f21aeb
Merge branch 'main' into feat/asl-4650-update-docx
kiran-varma-home-office Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
226 changes: 190 additions & 36 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/asl-internal-ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
"css-loader": "^5.0.0",
"csv-stringify": "^5.3.6",
"date-fns": "^3.6.0",
"docx": "5.0.0-rc4",
"docx": "^9.5.3",
Copy link
Copy Markdown
Collaborator

@mohomeoffice mohomeoffice Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kiran is there any way we could upgrade in logical order for example 5 to 6, 6 to 7, 7to 8 and then 8 to 9 instead of directly upgrading from 5 to 9

Copy link
Copy Markdown
Contributor Author

@kiran-varma-home-office kiran-varma-home-office Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure without investigating but that may take more time and effort. Not sure how good are older docs. All latest docs available are for latest version.

"express": "^4.18.2",
"filenamify": "^4.1.0",
"lodash": "^4.17.19",
Expand Down
2 changes: 1 addition & 1 deletion packages/asl-internal-ui/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ const config = merge(
{
test: /\.jsx?$/,
exclude: p => p.match(/node_modules/) &&
!p.match(/@joefitter\/docx/) &&
!p.match(/docx/) &&
!p.match(/@asl/) &&
!p.match(/bpk-/) &&
!p.match(/@ukhomeoffice/),
Expand Down
2 changes: 1 addition & 1 deletion packages/asl-pages/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"dependencies": {
"@asl/projects": "file:../asl-projects",
"@asl/service": "file:../asl-service",
"@joefitter/docx": "^4.7.0",
"docx": "^9.5.3",
"@ukhomeoffice/asl-components": "file:../asl-components",
"@ukhomeoffice/asl-constants": "file:../asl-constants",
"@ukhomeoffice/asl-dictionary": "file:../asl-dictionary",
Expand Down
Loading
Loading