Potential fix for code scanning alert no. 26: Missing rate limiting#397
Draft
farrukhishaq wants to merge 8 commits intomainfrom
Draft
Potential fix for code scanning alert no. 26: Missing rate limiting#397farrukhishaq wants to merge 8 commits intomainfrom
farrukhishaq wants to merge 8 commits intomainfrom
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…om user-controlled sources Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…ction Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/UKHomeOffice/aspel-workspace/security/code-scanning/26
Add an Express rate-limiting middleware to this reports router so requests to
GET /:reportare capped per client/IP over a time window.Best fix: use
express-rate-limitand apply it before the route handler (router.use(limiter)), so both streaming and non-streaming database paths are covered in one change without altering existing business logic.File to change
packages/asl-metrics/lib/reports/index.jsWhat to add
express-rate-limit.router.get('/:report', ...).This addresses both alert variants since both DB accesses happen inside the same route.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.