Test cleanup#570
Merged
Merged
Conversation
Collaborator
Author
|
Updates:
|
kaklise
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide a summary of the proposed changes, describe tests and documentation, and review the acknowledgement below.
Summary
The primary purpose of this PR is developer quality of life for testing. The two main issues addressed are:
These two issues are solved by introducing
conftest.py, a configuration file utilized by pytest. In this file we introduce logic that changes the working directory while testing to either a temp directory that is destroyed upon tests finishing or a custom directory that is not destroyed (for cases where the developer wants to investigate the test artifacts). Additionally, the MPL plotting backend is coerced to "Agg" which is non-interactive and prevents windows from spawning and blocking progress.Common directories used for testing are also stored in
conftest.pyso that they are easily importable by all test files in a uniform way (rather than repeating boilerplate path generations in ~40 files).Tests and documentation
n/a
AI Disclosure
If you submit code generated using AI tools:
Acknowledgement
By contributing to WNTR, I acknowledge that I have reviewed the software quality assurance guidelines and agree to the following terms and conditions for my contribution: