Skip to content

Fix wheel testing#574

Merged
kbonney merged 3 commits into
USEPA:mainfrom
kbonney:wheel-test
Jul 1, 2026
Merged

Fix wheel testing#574
kbonney merged 3 commits into
USEPA:mainfrom
kbonney:wheel-test

Conversation

@kbonney

@kbonney kbonney commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Summary

Wheel testing was failing because of issues with the filepaths declared in conftest.py.
This PR addresses this issue by making some minor tweaks to the test suite configuration:

  • Removed wntr/tests/init.py — tests are no longer a subpackage, so they don't get bundled into the wheel
  • Moved shared path constants out of conftest.py into a new _test_paths.py utility module. conftest is now purely pytest infrastructure (backend, CWD isolation), while path constants live somewhere that makes their purpose obvious
  • Updated all 40 test files to import from _test_paths instead of wntr.tests.conftest. This also fixes the CI wheel-test failure, since bare import _test_paths resolves from the local checkout rather than the installed package

Tests and Documentation

AI Disclosure

  • No AI tools were used in this contribution
  • I used AI tools in this contribution.

Acknowledgement

By contributing to WNTR, I acknowledge that I have reviewed the software quality assurance guidelines and agree to the following terms and conditions for my contribution:

  1. I agree that my contributions are submitted under the Revised BSD License.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.
  3. If code was generated using AI tools, I have disclosed the use of AI and reviewed all code for quality assurance, correctness, security, and licensing.
  • I have read and agree to the above acknowledgement

@kbonney
kbonney merged commit 4788178 into USEPA:main Jul 1, 2026
22 checks passed
@kbonney
kbonney deleted the wheel-test branch July 2, 2026 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant