Skip to content

Enhance guidelines for requirements and implementation#344

Draft
OceanEyeFF wants to merge 1 commit into
UfoMiao:mainfrom
OceanEyeFF:main
Draft

Enhance guidelines for requirements and implementation#344
OceanEyeFF wants to merge 1 commit into
UfoMiao:mainfrom
OceanEyeFF:main

Conversation

@OceanEyeFF

Copy link
Copy Markdown

Added guidelines for handling unclear requirements and implementation standards.

Description

增加少量提升严谨性的提示词到猫娘风格AGENTS.md

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

minor feature update.

Testing

  • Tests added/updated
  • All tests pass
  • Coverage maintained

Checklist

  • Code follows style guidelines
  • Self-review completed
  • Documentation updated
  • No new warnings introduced

Added guidelines for handling unclear requirements and implementation standards.
@OceanEyeFF OceanEyeFF marked this pull request as ready for review April 14, 2026 04:00
@OceanEyeFF OceanEyeFF marked this pull request as draft April 14, 2026 04:00
@qodo-free-for-open-source-projects

Copy link
Copy Markdown

Review Summary by Qodo

Add implementation guidelines to nekomata engineer prompt

📝 Documentation

Grey Divider

Walkthroughs

Description
• Added four implementation guidelines to nekomata engineer prompt
• Guidelines cover requirement clarification, minimal implementation, traceable changes, and
  verification standards
• Added reminder to always respond in Chinese-simplified
Diagram
flowchart LR
  A["Nekomata Engineer Prompt"] -->|Add Guidelines| B["Requirement Clarification"]
  A -->|Add Guidelines| C["Minimal Implementation"]
  A -->|Add Guidelines| D["Traceable Changes"]
  A -->|Add Guidelines| E["Verification Standards"]
  A -->|Add Reminder| F["Chinese-simplified Response"]
Loading

Grey Divider

File Changes

1. templates/common/output-styles/zh-CN/nekomata-engineer.md 📝 Documentation +6/-0

Add implementation guidelines and language requirement

• Added four new implementation guidelines emphasizing requirement clarification, minimal
 implementation, traceable changes, and verification standards
• Added language requirement reminder to always respond in Chinese-simplified
• Guidelines promote rigorous engineering practices and user-focused development approach

templates/common/output-styles/zh-CN/nekomata-engineer.md


Grey Divider

Qodo Logo

@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented Apr 14, 2026

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (1)   📘 Rule violations (1)   📎 Requirement gaps (0)
🐞\ ⚙ Maintainability (1)
📘\ ⚙ Maintainability (1)

Grey Divider


Action required

1. Added Chinese bullets in .md 📘
Description
New Chinese content was added to a Markdown documentation/template file outside README_zh-CN,
violating the English-only documentation requirement. This reduces consistency/maintainability for
the project’s developer-facing docs.
Code

templates/common/output-styles/zh-CN/nekomata-engineer.md[R88-91]

+- 遇到需求、上下文或边界不清晰时,优先明确假设;若无法通过现有信息验证,再向用户确认 (先求证再行动喵~)
+- 默认采用满足当前需求的最小实现,避免未经请求的抽象、配置化或未来功能预留 (克制设计,专注当下)
+- 修改应保持局部且可追溯,每一处变更都应直接服务于当前任务目标 (每一笔改动都要有意义)
+- 开始实现前先明确可验证的完成标准;能运行测试或检查时应主动验证,不能验证时需明确说明原因与风险 (验证让结果更可靠)
Evidence
PR Compliance ID 1 requires all Markdown documentation to be in English except README_zh-CN. The
added bullet lines in templates/common/output-styles/zh-CN/nekomata-engineer.md are Chinese, and
this file is not the allowed exception.

CLAUDE.md
templates/common/output-styles/zh-CN/nekomata-engineer.md[88-91]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
Non-English (Chinese) Markdown content was added in a `.md` file that is not `README_zh-CN`, which violates the repo requirement that documentation and comments be in English.

## Issue Context
This PR adds new guideline bullet points in Chinese under `templates/common/output-styles/zh-CN/nekomata-engineer.md`.

## Fix Focus Areas
- templates/common/output-styles/zh-CN/nekomata-engineer.md[88-91]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools



Remediation recommended

2. Duplicate language directive 🐞
Description
The zh-CN nekomata output-style template hard-codes a "Most Important: ... Chinese-simplified"
directive even though the project already manages output language via centralized directives
(CLAUDE.md for Claude, and AGENTS.md rewriting for Codex). This makes the template directive
redundant/overwritten in Codex installs and can introduce conflicting system instructions in Claude
setups when aiOutputLang is configured differently.
Code

templates/common/output-styles/zh-CN/nekomata-engineer.md[126]

+**Most Important:Always respond in Chinese-simplified**
Evidence
The template now contains a hard-coded language directive. Separately, init/config flows write the
selected AI output language into ~/.claude/CLAUDE.md, and the Codex installer explicitly
strips/replaces any existing "Most Important: Always respond in ..." line in AGENTS.md after writing
the chosen output-style template—so the template directive will not be the single source of truth
and may be overridden or conflict depending on environment/configuration.

templates/common/output-styles/zh-CN/nekomata-engineer.md[122-126]
src/utils/config.ts[376-396]
src/commands/init.ts[803-817]
src/utils/code-tools/codex.ts[1122-1129]
src/utils/code-tools/codex.ts[1831-1855]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`templates/common/output-styles/zh-CN/nekomata-engineer.md` adds a hard-coded `**Most Important:Always respond in Chinese-simplified**` line. The repo already has a centralized AI output language directive system (Claude: `~/.claude/CLAUDE.md`; Codex: post-process AGENTS.md), so embedding a fixed language directive inside a specific output-style template is redundant in Codex and can create conflicting instructions for Claude when `aiOutputLang` is set differently.

## Issue Context
- Claude init applies the chosen `aiOutputLang` by writing a single directive into `~/.claude/CLAUDE.md`.
- Codex init writes the chosen output-style file to `AGENTS.md`, then removes/replaces any existing `**Most Important: Always respond in ...**` directive based on `aiOutputLang`.

## Fix Focus Areas
- templates/common/output-styles/zh-CN/nekomata-engineer.md[122-126]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

Comment on lines +88 to +91
- 遇到需求、上下文或边界不清晰时,优先明确假设;若无法通过现有信息验证,再向用户确认 (先求证再行动喵~)
- 默认采用满足当前需求的最小实现,避免未经请求的抽象、配置化或未来功能预留 (克制设计,专注当下)
- 修改应保持局部且可追溯,每一处变更都应直接服务于当前任务目标 (每一笔改动都要有意义)
- 开始实现前先明确可验证的完成标准;能运行测试或检查时应主动验证,不能验证时需明确说明原因与风险 (验证让结果更可靠)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Added chinese bullets in .md 📘 Rule violation ⚙ Maintainability

New Chinese content was added to a Markdown documentation/template file outside README_zh-CN,
violating the English-only documentation requirement. This reduces consistency/maintainability for
the project’s developer-facing docs.
Agent Prompt
## Issue description
Non-English (Chinese) Markdown content was added in a `.md` file that is not `README_zh-CN`, which violates the repo requirement that documentation and comments be in English.

## Issue Context
This PR adds new guideline bullet points in Chinese under `templates/common/output-styles/zh-CN/nekomata-engineer.md`.

## Fix Focus Areas
- templates/common/output-styles/zh-CN/nekomata-engineer.md[88-91]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 65bf750937

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".


_记住,我是猫娘 幽浮喵,一个有着独立思考和专业技能的工程师,会始终保持这个身份为您提供最好的技术服务喵~_ (充满自信)

**Most Important:Always respond in Chinese-simplified**

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Remove hardcoded Chinese response override

This new directive forces nekomata-engineer to answer in Chinese even when users configured another output language, which creates conflicting instructions and can break English/custom-language setups. The installer currently always copies zh-CN style templates (src/utils/output-style.ts:333), so this line propagates to all installs of this style and can override the global language directive (applyAiLanguageDirective), making language behavior inconsistent across styles.

Useful? React with 👍 / 👎.

@WitMiao WitMiao Apr 16, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个语言限制不能在这个文件里 @OceanEyeFF

@codecov

codecov Bot commented Apr 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants