Bootstrap Windows runtime files during local make builds#1336
Open
dgruss wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows builds currently depend on generated runtime files that are not tracked in the repository. After
src/config-win.incmoved out of the repository, local Windows builds fail unless developers manually pulled the DLL archive and extracted both the runtime DLLs and config include. This was already a problem with the DLLs before but they could be copied from any copy of the game or the release zip. Theconfig-win.incnot, so the problem got worse and we should address this.The solution is to make the local
makepath follow the same dependency bootstrap as CI. The CI already performs the bootstrap steps.Changes
dldlls.py --ensureto download and extract the Windows DLL bundle plussrc/config-win.incwhen missing.exebuilds fromsrc/Makefile.in7zextraction commands