Skip to content

Bootstrap Windows runtime files during local make builds#1336

Open
dgruss wants to merge 1 commit into
UltraStar-Deluxe:masterfrom
dgruss:fixbuildonwindows
Open

Bootstrap Windows runtime files during local make builds#1336
dgruss wants to merge 1 commit into
UltraStar-Deluxe:masterfrom
dgruss:fixbuildonwindows

Conversation

@dgruss

@dgruss dgruss commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Windows builds currently depend on generated runtime files that are not tracked in the repository. After src/config-win.inc moved out of the repository, local Windows builds fail unless developers manually pulled the DLL archive and extracted both the runtime DLLs and config include. This was already a problem with the DLLs before but they could be copied from any copy of the game or the release zip. The config-win.inc not, so the problem got worse and we should address this.
The solution is to make the local make path follow the same dependency bootstrap as CI. The CI already performs the bootstrap steps.

Changes

  • add dldlls.py --ensure to download and extract the Windows DLL bundle plus src/config-win.inc when missing
  • run the helper before Windows .exe builds from src/Makefile.in
  • reuse the same helper in GitHub Actions instead of separate 7z extraction commands
  • document the local Windows build behavior

@dgruss
dgruss force-pushed the fixbuildonwindows branch from fa931c9 to aabd471 Compare June 4, 2026 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant