Remove song feature icons#1357
Draft
dgruss wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The discussion in #1345 made it clear that these icons are problematic due to overlap and, also currently they are not reliable unless we run the analysis on songs when they are displayed (which makes the interface lag). Rap is also not a very clear song-level feature because rap notes are sometimes used for unclear pitches in otherwise normal songs.
For medleys, this may become even less useful if medley mode is allowed for every song (if #1356 is a good idea).
Therefore, in this PR, we remove the following song feature icons: rap, rap-to-freestyle, tagged medley, calculated medley.
Any code and theme entries for these icons are removed as well. The unused files are also removed.