Skip to content

added some changes in Jenkinsfile#173

Open
AbhilashKD wants to merge 8 commits intomainfrom
staging
Open

added some changes in Jenkinsfile#173
AbhilashKD wants to merge 8 commits intomainfrom
staging

Conversation

@AbhilashKD
Copy link
Copy Markdown
Collaborator

No description provided.

Comment thread build/Jenkinsfile Outdated
sh '''
docker build -t $docker_server/$docker_repo:latest .
'''
} else if (env.BRANCH_NAME == 'main' || env.BRANCH_NAME == 'staging'){
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the logic here, and why for both main and staging? we are building latest tagged repo ?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is written
if any changes happens at main branch then it will pickup the command mentioned in that and if any changes push on staging then it will take that changes
and also in last stage it will deploy it according to changes pushed to respective
branch

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For main, it will never go to the second if. Please walk through the if else logic once. Also verify the tags again.

Copy link
Copy Markdown
Collaborator Author

@AbhilashKD AbhilashKD May 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes
but if it is for staging then ?
then it will go for 2nd na
?

Comment thread build/Jenkinsfile Outdated
Copy link
Copy Markdown
Collaborator Author

@AbhilashKD AbhilashKD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the typo error

@tushar5526
Copy link
Copy Markdown
Contributor

LGTM

@tushar5526
Copy link
Copy Markdown
Contributor

Please fix the merge conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants