Skip to content

Feat: [BADA-377] 게시물 찜 response에 MobileCarrier 추가#398

Merged
choyunju merged 1 commit intodevelopfrom
feature/BADA-377-add-mobilecarrier-to-post-likes
Aug 6, 2025
Merged

Feat: [BADA-377] 게시물 찜 response에 MobileCarrier 추가#398
choyunju merged 1 commit intodevelopfrom
feature/BADA-377-add-mobilecarrier-to-post-likes

Conversation

@choyunju
Copy link
Copy Markdown
Contributor

@choyunju choyunju commented Aug 6, 2025

#️⃣연관된 이슈

close: #397

🚀 작업 내용

  • 게시물 찜 response에 MobileCarrier 추가

🔍 리뷰 요청 사항

@choyunju choyunju added this to the 👤 사용자 milestone Aug 6, 2025
@choyunju choyunju self-assigned this Aug 6, 2025
@choyunju choyunju added the ✨ Feature 기능 개발 label Aug 6, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 6, 2025

Failed to generate code suggestions for PR

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Aug 6, 2025

Walkthrough

GetLikesPostResponse DTO 클래스에 mobileCarrier 필드가 새로 추가되었습니다. 이와 함께, 정적 팩토리 메서드 from이 수정되어, 전달받은 Post 객체가 Data 타입인 경우에만 해당 엔티티에서 mobileCarrier 값을 추출해 할당하도록 변경되었습니다. GifticonData 타입에 따라 기존에 분기 처리하던 로직에 이 필드가 추가로 반영되었습니다.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between db2e8b1 and 69f7ec4.

📒 Files selected for processing (1)
  • src/main/java/com/TwoSeaU/BaData/domain/user/dto/response/GetLikesPostResponse.java (3 hunks)
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: choyunju
PR: Ureca-Final-Project-Team2/be_badata#132
File: src/main/java/com/TwoSeaU/BaData/domain/user/dto/response/GetFollowsResponse.java:25-25
Timestamp: 2025-07-17T13:03:43.601Z
Learning: choyunju prefers intuitive field naming in DTOs - even if the API response could use generic names like "username", they prefer to use descriptive field names like "nickname" that clearly indicate the actual data being returned for better code clarity and maintainability.
Learnt from: choyunju
PR: Ureca-Final-Project-Team2/be_badata#267
File: src/main/java/com/TwoSeaU/BaData/domain/user/controller/UserController.java:151-154
Timestamp: 2025-07-28T01:13:39.883Z
Learning: choyunju는 프론트엔드에서 토글 형식으로 구현된 Boolean 파라미터의 경우, null 값이 들어올 수 없다고 판단하여 별도의 null 검증 로직을 추가하지 않는 것을 선호한다. 프론트엔드와 백엔드 간의 계약이 명확할 때 중복 검증을 피하는 설계 접근법을 취한다.
📚 Learning: in the updatepostrequest class at src/main/java/com/twoseau/badata/domain/trade/dto/request/updatepo...
Learnt from: marineAqu
PR: Ureca-Final-Project-Team2/be_badata#146
File: src/main/java/com/TwoSeaU/BaData/domain/trade/dto/request/UpdatePostRequest.java:5-5
Timestamp: 2025-07-18T05:48:30.088Z
Learning: In the UpdatePostRequest class at src/main/java/com/TwoSeaU/BaData/domain/trade/dto/request/UpdatePostRequest.java, the user explicitly stated they don't use the default constructor and are handling JSON deserialization differently, rejecting the suggestion to add NoArgsConstructor alongside AllArgsConstructor.

Applied to files:

  • src/main/java/com/TwoSeaU/BaData/domain/user/dto/response/GetLikesPostResponse.java
📚 Learning: in java, when classes are in the same package, no import statement is needed. classes in the same pa...
Learnt from: marineAqu
PR: Ureca-Final-Project-Team2/be_badata#118
File: src/main/java/com/TwoSeaU/BaData/domain/trade/entity/Payment.java:32-32
Timestamp: 2025-07-15T06:31:54.894Z
Learning: In Java, when classes are in the same package, no import statement is needed. Classes in the same package can reference each other directly without explicit imports. This applies to the Post entity in the Payment.java file where both are in the com.TwoSeaU.BaData.domain.trade.entity package.

Applied to files:

  • src/main/java/com/TwoSeaU/BaData/domain/user/dto/response/GetLikesPostResponse.java
🔇 Additional comments (4)
src/main/java/com/TwoSeaU/BaData/domain/user/dto/response/GetLikesPostResponse.java (4)

3-3: LGTM! 필요한 import 추가가 올바르게 되었습니다.

새로운 mobileCarrier 필드와 관련 로직을 위해 필요한 Data 엔티티와 MobileCarrier enum import가 적절히 추가되었습니다.

Also applies to: 7-7


27-27: LGTM! 필드 추가가 적절합니다.

mobileCarrier 필드가 기존 코드 패턴과 일관성 있게 추가되었으며, 직관적인 필드명으로 명명되어 코드 가독성이 향상되었습니다.


40-40: LGTM! 팩토리 메서드 수정이 기존 패턴과 일관성 있게 구현되었습니다.

Data 타입 게시물에서만 mobileCarrier 값을 추출하는 로직이 기존의 partner 필드 처리 방식과 동일한 패턴으로 구현되어 일관성이 유지되었습니다. 패턴 매칭을 사용한 현대적인 Java 문법도 적절합니다.


34-47: 전체 구현이 PR 목표를 성공적으로 달성했습니다.

게시물 찜 응답에 MobileCarrier 필드가 성공적으로 추가되었으며, 기존 코드 패턴을 잘 따르고 있습니다. Data 타입 게시물에서만 모바일 캐리어 정보를 제공하는 비즈니스 로직이 올바르게 구현되었습니다.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/BADA-377-add-mobilecarrier-to-post-likes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 6, 2025

Overall Project 19.1%

There is no coverage information present for the Files changed

@choyunju choyunju merged commit bcb1918 into develop Aug 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ Feature 기능 개발

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BADA-377] [FEAT] 게시물 찜 목록 response에 MobileCarrier 추가

2 participants