Skip to content

Patches PR following the 2025-08-25 Evil Dev Stream test! - #88

Merged
Pasu4 merged 70 commits into
devfrom
patch/dev-stream
Sep 3, 2025
Merged

Patches PR following the 2025-08-25 Evil Dev Stream test!#88
Pasu4 merged 70 commits into
devfrom
patch/dev-stream

Conversation

@KTrain5169

@KTrain5169 KTrain5169 commented Aug 26, 2025

Copy link
Copy Markdown
Member

@KTrain5169's list:

Functional changes

  • When switching files by a human, context isn't sent, this is a bit of a problem for "student-pilot" as vedal switching files may not be made clear to the twins & they don't get a refresh on the file's contents (Implemented in fb4aa2c)
  • Evil tries to input position parameters in insert text instead of moving the cursor first and then inserting text, this should be allowed and all schemas must now have additionalProperties: false for the schema lib (unless we just add a custom check for that at RCE instead of back-adding that to every schema) (Implemented in b942e11 (position parameters) and 8354ef6 (additionalProperties))
  • A different option for regex text should be available as an option for replace/delete - Glob patterns probably weren't tried during stream. Probably should've realised that much earlier but oh well.
  • Range options should be specifiable for replace/delete (Implemented in b0d0cb8)
    • This should be used to limit the range to replace and delete text.
  • actually while we're at it the cursor should also have the ability to highlight like clicking and dragging text like a range (Implemented in df8dbbb)

Config/context changes

  • CNAME shouldn't be neuro-safe by default (currently is because it doesn't start with a dot and lives at root, not a subfolder)
  • perhaps should be made clear to evil that binary files like .png are gibberish (is there even a way to tell if a file is binary without trying to parse it?) (Implemented in 8e812ad)

@Pasu4's list:

General changes

  • Specify to use newlines and indentation appropriately for insert_text. (Implemented in 5a8cd5d)
  • The user should be able to disable specific actions by name. (Implemented in c2644db)
    • VS Code settings UI might get a bit messy if this was implemented, so something like .neuropilot/ #51 and/or a sidebar to contain toggles should be used here instead. @KTrain5169 learned something new and that was array schemas for extension settings.
  • The entire file should be sent as context. (Kinda implemented in dbe0f3d)
    • Maybe a max length failsafe would be good in case she does something with regex replace again, but what should happen in that case?
  • If an action moves the cursor, it should be mentioned in its description. (Implemented in 8151bb7)
  • Show Neuro's last edit using text decorations. (Implemented in 41f8f67)

New actions

Issues to also resolve with this branch:

@KTrain5169 KTrain5169 added this to the v2.1.0 milestone Aug 26, 2025
@KTrain5169
KTrain5169 requested a review from Pasu4 August 26, 2025 12:20
@KTrain5169 KTrain5169 added the enhancement New feature or request label Aug 26, 2025
KTrain5169 and others added 4 commits August 26, 2025 22:20
additionalProperties is marked as probably not supported by the specification, but this should be fine since we validate against the schema
@KTrain5169

Copy link
Copy Markdown
Member Author

@Pasu4 I'm currently working on adding the position parameters for the editing actions. If you're going to continue making it (probably better rn), my suggestion is to refactor the schema object so that position parameters are deduplicated from the move cursor action and insert text action. Also, parameters should be a separate object inside the schema so that we can mark both line & column as required, but not if she doesn't input position params (unless we don't want to make both required at once and instead just default to cursor, I think I discussed this on Neurocord but I'm not entirely sure if that's a good idea now)

@KTrain5169 KTrain5169 added documentation Improvements or additions to documentation new action A new action Neuro can execute refactor Improving existing code without changing external behavior labels Aug 26, 2025
@KTrain5169 KTrain5169 moved this to 2025-08-25 in 2025-08-25 Evil Dev Stream Aug 26, 2025
@Pasu4

Pasu4 commented Aug 26, 2025

Copy link
Copy Markdown
Member

Also, parameters should be a separate object inside the schema so that we can mark both line & column as required, but not if she doesn't input position params

Probably better than my current (uncommitted) implementation, so I'll leave this to you if you're already on it. Also, additionalProperties isn't recursive so you need to add it to the inner object (just saying this in case you didn't know).

VS Code settings UI might get a bit messy if this was implemented, so something like #51 and/or a sidebar to contain toggles should be used here instead.

I was more thinking of a string list setting of disabled action names, I don't think that would get messy. I'll try it tomorrow to see if it's really that bad.

@KTrain5169

KTrain5169 commented Aug 27, 2025 via email

Copy link
Copy Markdown
Member Author

@changeset-bot

changeset-bot Bot commented Aug 27, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 7f33ad6

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@KTrain5169

KTrain5169 commented Sep 1, 2025

Copy link
Copy Markdown
Member Author

@Pasu4 I did a bit of looking for you regarding the read_file action, you can read a file, get its Uint8Array value, and parse it using Buffer.from(fileData).toString('utf8');. I've already done the binary file validator (which uses the same sort of logic but looks at the Uint8Array value directly), so you can use that to validate that she isn't going to get a load of binary rubbish first.

I don't think there's a simpler way unless the text editor is already open.

@KTrain5169
KTrain5169 marked this pull request as ready for review September 3, 2025 07:15
@KTrain5169
KTrain5169 requested a review from Pasu4 September 3, 2025 07:15
@Pasu4
Pasu4 merged commit 1e57b83 into dev Sep 3, 2025
4 checks passed
@Pasu4
Pasu4 deleted the patch/dev-stream branch September 3, 2025 10:16
@github-project-automation github-project-automation Bot moved this from 2025-08-25 to Far down on the road... in 2025-08-25 Evil Dev Stream Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request new action A new action Neuro can execute refactor Improving existing code without changing external behavior

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

3 participants