Patches PR following the 2025-08-25 Evil Dev Stream test! - #88
Conversation
additionalProperties is marked as probably not supported by the specification, but this should be fine since we validate against the schema
|
@Pasu4 I'm currently working on adding the position parameters for the editing actions. If you're going to continue making it (probably better rn), my suggestion is to refactor the schema object so that position parameters are deduplicated from the move cursor action and insert text action. Also, parameters should be a separate object inside the schema so that we can mark both line & column as required, but not if she doesn't input position params (unless we don't want to make both required at once and instead just default to cursor, I think I discussed this on Neurocord but I'm not entirely sure if that's a good idea now) |
Probably better than my current (uncommitted) implementation, so I'll leave this to you if you're already on it. Also,
I was more thinking of a string list setting of disabled action names, I don't think that would get messy. I'll try it tomorrow to see if it's really that bad. |
|
Also, additionalProperties isn't recursive so you need to add it to the inner object (just saying this in case you didn't know).
No I remembered earlier today, but I did forget yesterday. I'll make sure to add that to my commits.
I was more thinking of a string list setting of disabled action names, I don't think that would get messy. I'll try it tomorrow to see if it's really that bad.
String lists with \n are something I want to avoid simply because it's not typo-proof, at least with .neuropilot/ we can add a schema that says "hey by the way, this is a non-existent action" but I'll leave that up to you.
|
…neuropilot into patch/dev-stream
🦋 Changeset detectedLatest commit: 7f33ad6 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@Pasu4 I did a bit of looking for you regarding the read_file action, you can read a file, get its Uint8Array value, and parse it using I don't think there's a simpler way unless the text editor is already open. |
…cause lint errors are annoying the script only works on the disabledActions setting's enum
…sktop i sitll don't want to have to fiure out git extension testing
@KTrain5169's list:
Functional changes
additionalProperties: falsefor the schema lib (unless we just add a custom check for that at RCE instead of back-adding that to every schema) (Implemented in b942e11 (position parameters) and 8354ef6 (additionalProperties))Config/context changes
@Pasu4's list:
General changes
insert_text. (Implemented in 5a8cd5d)VS Code settings UI might get a bit messy if this was implemented, so something like .neuropilot/ #51 and/or a sidebar to contain toggles should be used here instead.@KTrain5169 learned something new and that was array schemas for extension settings.New actions
get_content: Get the content of the current file. (Implemented in a2f4fcc)Send Current File as Contextcommand, or use the same code.insert_lines: Insert lines of code below the specified line. (Fully implemented in 269136b)\ncharacters in the action object?rewrite_lines: Rewrite everything in the specified line range. (Implemented in Add rewrite_lines action and implement character limit validation #94)delete_lines: Delete everything in the specified line range. (Implemented in Add delete_lines action & update replace_lines cursor behavior to be in line with the other actions #95)rewrite_all: Rewrite the entire contents of the file. (Implemented in Rewrite all action #93)read_file: Send the contents of a file as context without opening / switching to it. (Implemented in 9229cb0)Issues to also resolve with this branch:
devbranch)