[TF2] Fix Demoman Charge Meter#1895
Open
ThatFriendlyWolf wants to merge 3 commits intoValveSoftware:masterfrom
Open
[TF2] Fix Demoman Charge Meter#1895ThatFriendlyWolf wants to merge 3 commits intoValveSoftware:masterfrom
ThatFriendlyWolf wants to merge 3 commits intoValveSoftware:masterfrom
Conversation
Fixes the incorrect value used for the crit section. Implements the same attribute check that the Tide Turner uses to disable crits.
FlaminSarge
reviewed
Apr 26, 2026
| } | ||
| else | ||
| { | ||
| m_pChargeMeter->SetFgColor( Color( 255, 255, 255, 255 ) ); |
Contributor
There was a problem hiding this comment.
While it's recharging, do you think it's worth setting the color to grey so that it has a visible color change when it's full (grey to white)?
Author
There was a problem hiding this comment.
Seeing how the other meters do not have this type of effect (other than the vaccinator charge which is a entirely different meter) I believe it would be best to keep it as is to keep it consistent with the other meters that are used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, in live TF2, the charge meter for Demoman does not factor in the stat that makes it only mini crit (for the Tide Turner).
Alongside this it does not properly reflect the color range properly.
This pull request tries to fix this so that it is a lot more reliable to use.
Changing it so that the charge meter does not display the crit colors for the Tide Turner, while also fixing the percentage to line up with what is actually used.