refactor: Updated main.bicep and other modules#2
Open
Vamshi-Microsoft wants to merge 28 commits into
Open
Conversation
feat: Added Basix code set up
Vamshi-Microsoft
changed the title
Prajwal-Microsoft
changed the base branch from
avm/ptn/sa/build-your-own-copilot-solution-accelerator
to
main
- Changed allowBlobPublicAccess logic to enhance security. - Added delete retention policy settings for blob services. - Introduced maintenance window resource for SQL database. - Adjusted SKU capacity and replica count for better performance. - Updated availability zone for Jumpbox VM deployment.
- Introduced `enableSqlVulnerabilityAssessment` parameter to enable SQL vulnerability assessment scanning. - Updated README and main.bicep to reflect the new parameter and its default value. - Adjusted main.json to include the new parameter in the module's schema.
… module - Added maintenance configuration module for Jumpbox VM to manage in-guest patching. - Updated Jumpbox and Bastion Host configurations to include availability zones. - Modified main.json and README.md to reflect changes in resource types and versions.
- Introduced a mapping for SQL Database maintenance configurations based on Azure regions. - Enabled hierarchical namespace for storage account. - Updated maintenance window resource to use dynamic configuration name based on location. - Adjusted SQL database module to conditionally set maintenance configuration ID. - Added security alert policies for SQL vulnerability assessment.
…aintenanceConfiguration issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces new infrastructure modules and a workflow for the "build-your-own-copilot-solution-accelerator" in Azure, focusing on Cognitive Services, AI Search connectivity, and Key Vault secret management. The changes add reusable and parameterized Bicep modules for deploying and configuring these resources, alongside a GitHub Actions workflow to automate deployments and validations.
New infrastructure modules for Azure resources:
ai-services.bicepmodule to deploy and configure Azure Cognitive Services accounts, supporting advanced options like managed identities, customer-managed keys, network controls, private endpoints, role assignments, and secret exports. This module also defines types for endpoints, deployments, and secret export configurations.deploy_aifp_aisearch_connection.bicepmodule to establish a connection between an AI Foundry project and Azure Cognitive Search, including authentication and metadata configuration.keyVaultExport.bicepmodule to automate exporting secrets to an Azure Key Vault, with support for setting multiple secrets and outputting references to the created secrets.Deployment automation and workflow:
.github/workflows/avm.ptn.sa.build-your-own-copilot-solution-accelerator.ymlto orchestrate deployments, including static and deployment validations, removal of deployed modules, and support for custom locations. The workflow initializes pipeline parameters, collects test file paths, and calls a reusable workflow for actual deployment.Pipeline Reference
Type of Change
version.json:version.json.version.json.Checklist
Set-AVMModulelocally to generate the supporting module files.