docs(CONTRIBUTING): spell out Mathlib capitalization rules - #366
Merged
dtumad merged 2 commits intoMay 2, 2026
Merged
Conversation
…rules The previous one-line "Follow Mathlib naming conventions where possible" left too much room for interpretation — most notably, the AI style-adherence step in the PR-summary workflow does not have access to the actual Mathlib naming guide and was inferring rules (e.g. flagging `lowerCamelCase` definitions as violations because Mathlib supposedly uses `snake_case` for definitions). Quote the four capitalization rules verbatim from the Mathlib naming guide so both contributors and any tool handed `CONTRIBUTING.md` as a style reference have the actual conventions to check against. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
🤖 PR SummaryDocumentation
Statistics
Lean Declarations
🎨 **Style Guide Adherence**All changes adhere to the style guide. 📄 **Per-File Summaries**
Last updated: 2026-05-02 14:39 UTC. |
dtumad
enabled auto-merge (squash)
May 2, 2026 14:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed on my other PR that the review bot uses this file as its style guide. But it runs on gemini 3 and I think it doesn't know what the capitalization conventions are / that lean4 changed them, so I have added some points from the official mathlib guide to make sure it will not mess these up.