proofs for probabilitytheory/coupling - #263
Merged
Merged
Conversation
Collaborator
|
PR summary generation is failing with "Gemini API call failed." https://github.com/Verified-zkEVM/iris-lean/actions/runs/21909475339/job/63308939728?pr=263 |
Author
but that cant be because of my code change I think. I only changed coupling.lean. Something to do with the workflow file here perhaps. may be @alexanderlhicks could setup the API tokens etc |
- Remove unnecessary `by exact` wrappers in IsCoupling.map and IsCoupling.symm - Simplify Lift.graph proof using grind tactic - No behavioral changes, purely syntactic improvements Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
… subset_singleton_iff Reduce verbosity in Coupling.lean by: eliminating intermediate `have` bindings for composition equalities (using inline `show ... from rfl`), leveraging `Set.Nonempty.subset_singleton_iff` for support equality proofs, collapsing case splits with `by_cases`, and inlining support membership witnesses. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace `by ext ⟨a, b⟩; rfl` with just `rfl` in SPMF.IsCoupling.map and SPMF.IsCoupling.symm. Lean's definitional equality handles these function compositions directly without explicit extensionality. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
pirapira
approved these changes
Feb 11, 2026
pirapira
left a comment
pirapira
left a comment
Collaborator
There was a problem hiding this comment.
I tried simplifying the proof a bit (with Claude Code too).
Looks good to me.
This was referenced Feb 11, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude Opus enabled. Just a side note that not all the theorems came in SPMF/PMF pairs in the coupling.lean file even though there were some issues created. Not sure that was an oversight or not but thought I would mention it. I have commented on the duplicate issues.