test: add coverage for TransactionNotification - #263
Open
Anichris-koded wants to merge 1 commit into
Open
Conversation
Covers all four VoteTxState branches (idle, pending, success, error) plus dismiss behavior and the success-without-txHash guard. - idle: renders null - pending: role=status, aria-live=polite, spinner icon, translated message - success: role=status, explorer link URL/target/rel, success icon - error/network_error: role=alert, aria-live=assertive, correct message - error/user_rejected: user-rejected message, network message absent - dismiss button: fires onDismiss, absent without prop, absent in non-error states - success with txHash=null: renders null Closes Vero-protocol#254
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds unit/component tests for
src/components/TransactionNotification/as requested in #254.What's covered
idlenullpendingrole=status,aria-live=polite, spinner icon, translated messagesuccessrole=status, success message, explorer link (URL,target=_blank,rel=noopener noreferrer), iconerror / network_errorrole=alert,aria-live=assertive, network error message, user-rejected message absenterror / user_rejectedonDismisson click; absent without prop; absent inpendingandsuccessstatessuccesswithtxHash=nullnull(guard branch)21 tests, all passing under
npm test.Testing
Closes #254